From 9fb3add94f7cb4ffaf41137c92934bfacbc6915c Mon Sep 17 00:00:00 2001 From: chandralekha Date: Fri, 10 May 2024 19:45:02 +0530 Subject: [PATCH] Updated SME review comments. --- .../{TermsWarnings => }/.vale.ini | 2 +- .../CommonlyMisusedWords/TermsErrors/.vale.ini | 5 ----- .../TermsErrors/testinvalid.adoc | 6 ------ .../TermsErrors/testvalid.adoc | 8 -------- .../TermsSuggestions/.vale.ini | 5 ----- .../TermsSuggestions/testinvalid.adoc | 5 ----- .../TermsSuggestions/testvalid.adoc | 5 ----- .../TermsWarnings/testinvalid.adoc | 13 ------------- .../TermsWarnings/testvalid.adoc | 11 ----------- .../CommonlyMisusedWords/testinvalid.adoc | 3 +++ .../CommonlyMisusedWords/testvalid.adoc | 6 ++++++ .../TermsWarnings => Modals}/.vale.ini | 2 +- .../Localization/Modals/TermsErrors/.vale.ini | 5 ----- .../Modals/TermsErrors/testinvalid.adoc | 6 ------ .../Modals/TermsErrors/testvalid.adoc | 8 -------- .../Modals/TermsSuggestions/.vale.ini | 5 ----- .../Modals/TermsSuggestions/testinvalid.adoc | 5 ----- .../Modals/TermsSuggestions/testvalid.adoc | 5 ----- .../Modals/{TermsWarnings => }/testinvalid.adoc | 0 .../Modals/{TermsWarnings => }/testvalid.adoc | 0 .../.vale.ini | 2 +- .../TermsErrors/.vale.ini | 5 ----- .../TermsErrors/testinvalid.adoc | 6 ------ .../TermsErrors/testvalid.adoc | 8 -------- .../TermsSuggestions/.vale.ini | 5 ----- .../TermsSuggestions/testinvalid.adoc | 5 ----- .../TermsSuggestions/testvalid.adoc | 5 ----- .../{TermsWarnings => }/testinvalid.adoc | 0 .../{TermsWarnings => }/testvalid.adoc | 0 ...TermsWarnings.yml => CommonlyMisusedWords.yml} | 10 ---------- .../CommonlyMisusedWords/TermsErrors.yml | 15 --------------- .../CommonlyMisusedWords/TermsSuggestions.yml | 14 -------------- .../{Modals/TermsWarnings.yml => Modals.yml} | 0 .vale/styles/Localization/Modals/TermsErrors.yml | 15 --------------- .../Localization/Modals/TermsSuggestions.yml | 14 -------------- ...Warnings.yml => WordswithMultipleMeanings.yml} | 0 .../WordswithMultipleMeanings/TermsErrors.yml | 15 --------------- .../TermsSuggestions.yml | 14 -------------- 38 files changed, 12 insertions(+), 226 deletions(-) rename .vale/fixtures/Localization/CommonlyMisusedWords/{TermsWarnings => }/.vale.ini (59%) delete mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/.vale.ini delete mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/testinvalid.adoc delete mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/testvalid.adoc delete mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/.vale.ini delete mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/testinvalid.adoc delete mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/testvalid.adoc delete mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/testinvalid.adoc delete mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/testvalid.adoc create mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/testinvalid.adoc create mode 100644 .vale/fixtures/Localization/CommonlyMisusedWords/testvalid.adoc rename .vale/fixtures/Localization/{WordswithMultipleMeanings/TermsWarnings => Modals}/.vale.ini (61%) delete mode 100644 .vale/fixtures/Localization/Modals/TermsErrors/.vale.ini delete mode 100644 .vale/fixtures/Localization/Modals/TermsErrors/testinvalid.adoc delete mode 100644 .vale/fixtures/Localization/Modals/TermsErrors/testvalid.adoc delete mode 100644 .vale/fixtures/Localization/Modals/TermsSuggestions/.vale.ini delete mode 100644 .vale/fixtures/Localization/Modals/TermsSuggestions/testinvalid.adoc delete mode 100644 .vale/fixtures/Localization/Modals/TermsSuggestions/testvalid.adoc rename .vale/fixtures/Localization/Modals/{TermsWarnings => }/testinvalid.adoc (100%) rename .vale/fixtures/Localization/Modals/{TermsWarnings => }/testvalid.adoc (100%) rename .vale/fixtures/Localization/{Modals/TermsWarnings => WordswithMultipleMeanings}/.vale.ini (57%) delete mode 100644 .vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/.vale.ini delete mode 100644 .vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/testinvalid.adoc delete mode 100644 .vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/testvalid.adoc delete mode 100644 .vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/.vale.ini delete mode 100644 .vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/testinvalid.adoc delete mode 100644 .vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/testvalid.adoc rename .vale/fixtures/Localization/WordswithMultipleMeanings/{TermsWarnings => }/testinvalid.adoc (100%) rename .vale/fixtures/Localization/WordswithMultipleMeanings/{TermsWarnings => }/testvalid.adoc (100%) rename .vale/styles/Localization/{CommonlyMisusedWords/TermsWarnings.yml => CommonlyMisusedWords.yml} (77%) delete mode 100644 .vale/styles/Localization/CommonlyMisusedWords/TermsErrors.yml delete mode 100644 .vale/styles/Localization/CommonlyMisusedWords/TermsSuggestions.yml rename .vale/styles/Localization/{Modals/TermsWarnings.yml => Modals.yml} (100%) delete mode 100644 .vale/styles/Localization/Modals/TermsErrors.yml delete mode 100644 .vale/styles/Localization/Modals/TermsSuggestions.yml rename .vale/styles/Localization/{WordswithMultipleMeanings/TermsWarnings.yml => WordswithMultipleMeanings.yml} (100%) delete mode 100644 .vale/styles/Localization/WordswithMultipleMeanings/TermsErrors.yml delete mode 100644 .vale/styles/Localization/WordswithMultipleMeanings/TermsSuggestions.yml diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/.vale.ini b/.vale/fixtures/Localization/CommonlyMisusedWords/.vale.ini similarity index 59% rename from .vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/.vale.ini rename to .vale/fixtures/Localization/CommonlyMisusedWords/.vale.ini index da0c8aa..daa4959 100644 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/.vale.ini +++ b/.vale/fixtures/Localization/CommonlyMisusedWords/.vale.ini @@ -1,4 +1,4 @@ -; Vale configuration file to test the `TermsWarnings` rule +; Vale configuration file to test the `CommonlyMisusedWords` rule StylesPath = ../../../styles MinAlertLevel = warning [*.adoc] diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/.vale.ini b/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/.vale.ini deleted file mode 100644 index d519f8e..0000000 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/.vale.ini +++ /dev/null @@ -1,5 +0,0 @@ -; Vale configuration file to test the `TermsErrors` rule -StylesPath = ../../../styles -MinAlertLevel = suggestion -[*.adoc] -Localization.TermsErrors = YES diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/testinvalid.adoc b/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/testinvalid.adoc deleted file mode 100644 index 80f6b6a..0000000 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/testinvalid.adoc +++ /dev/null @@ -1,6 +0,0 @@ -// Example entries: -// 10BASET -// 24/7 -// a lot -// a number of -// abort diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/testvalid.adoc b/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/testvalid.adoc deleted file mode 100644 index 2b837f3..0000000 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsErrors/testvalid.adoc +++ /dev/null @@ -1,8 +0,0 @@ -// Example entries: -// /etc -// /etc/ -// 10BASE-T -// 10BASE2 -// 12.00 AM -// 24x7 -// a or b diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/.vale.ini b/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/.vale.ini deleted file mode 100644 index 74095b3..0000000 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/.vale.ini +++ /dev/null @@ -1,5 +0,0 @@ -; Vale configuration file to test the `TermsSuggestions` rule -StylesPath = ../../../styles -MinAlertLevel = suggestion -[*.adoc] -Localization.TermsSuggestions = YES diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/testinvalid.adoc b/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/testinvalid.adoc deleted file mode 100644 index 915b9a0..0000000 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/testinvalid.adoc +++ /dev/null @@ -1,5 +0,0 @@ -// Example entries: -// above -// afterwards -// all caps -// bare metal clusters diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/testvalid.adoc b/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/testvalid.adoc deleted file mode 100644 index b2c3c35..0000000 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsSuggestions/testvalid.adoc +++ /dev/null @@ -1,5 +0,0 @@ -// Example entries: -// 64-bit x86 -// bare-metal clusters -// bare-metal compute -// bare-metal configuration diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/testinvalid.adoc b/.vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/testinvalid.adoc deleted file mode 100644 index 996261c..0000000 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/testinvalid.adoc +++ /dev/null @@ -1,13 +0,0 @@ -allow -acronym -etc -ie -eg -ex -via -versus -et cetera -per se -vice versa -won’t - diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/testvalid.adoc b/.vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/testvalid.adoc deleted file mode 100644 index 8c85c08..0000000 --- a/.vale/fixtures/Localization/CommonlyMisusedWords/TermsWarnings/testvalid.adoc +++ /dev/null @@ -1,11 +0,0 @@ -after -one time -because -during -at the same time -might -enable -abbreviation -can -cannot - diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/testinvalid.adoc b/.vale/fixtures/Localization/CommonlyMisusedWords/testinvalid.adoc new file mode 100644 index 0000000..cee4bfc --- /dev/null +++ b/.vale/fixtures/Localization/CommonlyMisusedWords/testinvalid.adoc @@ -0,0 +1,3 @@ +allow +acronym + diff --git a/.vale/fixtures/Localization/CommonlyMisusedWords/testvalid.adoc b/.vale/fixtures/Localization/CommonlyMisusedWords/testvalid.adoc new file mode 100644 index 0000000..99dc371 --- /dev/null +++ b/.vale/fixtures/Localization/CommonlyMisusedWords/testvalid.adoc @@ -0,0 +1,6 @@ +might +enable +abbreviation +can +cannot + diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsWarnings/.vale.ini b/.vale/fixtures/Localization/Modals/.vale.ini similarity index 61% rename from .vale/fixtures/Localization/WordswithMultipleMeanings/TermsWarnings/.vale.ini rename to .vale/fixtures/Localization/Modals/.vale.ini index da0c8aa..ea5f042 100644 --- a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsWarnings/.vale.ini +++ b/.vale/fixtures/Localization/Modals/.vale.ini @@ -1,4 +1,4 @@ -; Vale configuration file to test the `TermsWarnings` rule +; Vale configuration file to test the `Modals` rule StylesPath = ../../../styles MinAlertLevel = warning [*.adoc] diff --git a/.vale/fixtures/Localization/Modals/TermsErrors/.vale.ini b/.vale/fixtures/Localization/Modals/TermsErrors/.vale.ini deleted file mode 100644 index d519f8e..0000000 --- a/.vale/fixtures/Localization/Modals/TermsErrors/.vale.ini +++ /dev/null @@ -1,5 +0,0 @@ -; Vale configuration file to test the `TermsErrors` rule -StylesPath = ../../../styles -MinAlertLevel = suggestion -[*.adoc] -Localization.TermsErrors = YES diff --git a/.vale/fixtures/Localization/Modals/TermsErrors/testinvalid.adoc b/.vale/fixtures/Localization/Modals/TermsErrors/testinvalid.adoc deleted file mode 100644 index 80f6b6a..0000000 --- a/.vale/fixtures/Localization/Modals/TermsErrors/testinvalid.adoc +++ /dev/null @@ -1,6 +0,0 @@ -// Example entries: -// 10BASET -// 24/7 -// a lot -// a number of -// abort diff --git a/.vale/fixtures/Localization/Modals/TermsErrors/testvalid.adoc b/.vale/fixtures/Localization/Modals/TermsErrors/testvalid.adoc deleted file mode 100644 index 2b837f3..0000000 --- a/.vale/fixtures/Localization/Modals/TermsErrors/testvalid.adoc +++ /dev/null @@ -1,8 +0,0 @@ -// Example entries: -// /etc -// /etc/ -// 10BASE-T -// 10BASE2 -// 12.00 AM -// 24x7 -// a or b diff --git a/.vale/fixtures/Localization/Modals/TermsSuggestions/.vale.ini b/.vale/fixtures/Localization/Modals/TermsSuggestions/.vale.ini deleted file mode 100644 index 74095b3..0000000 --- a/.vale/fixtures/Localization/Modals/TermsSuggestions/.vale.ini +++ /dev/null @@ -1,5 +0,0 @@ -; Vale configuration file to test the `TermsSuggestions` rule -StylesPath = ../../../styles -MinAlertLevel = suggestion -[*.adoc] -Localization.TermsSuggestions = YES diff --git a/.vale/fixtures/Localization/Modals/TermsSuggestions/testinvalid.adoc b/.vale/fixtures/Localization/Modals/TermsSuggestions/testinvalid.adoc deleted file mode 100644 index 915b9a0..0000000 --- a/.vale/fixtures/Localization/Modals/TermsSuggestions/testinvalid.adoc +++ /dev/null @@ -1,5 +0,0 @@ -// Example entries: -// above -// afterwards -// all caps -// bare metal clusters diff --git a/.vale/fixtures/Localization/Modals/TermsSuggestions/testvalid.adoc b/.vale/fixtures/Localization/Modals/TermsSuggestions/testvalid.adoc deleted file mode 100644 index b2c3c35..0000000 --- a/.vale/fixtures/Localization/Modals/TermsSuggestions/testvalid.adoc +++ /dev/null @@ -1,5 +0,0 @@ -// Example entries: -// 64-bit x86 -// bare-metal clusters -// bare-metal compute -// bare-metal configuration diff --git a/.vale/fixtures/Localization/Modals/TermsWarnings/testinvalid.adoc b/.vale/fixtures/Localization/Modals/testinvalid.adoc similarity index 100% rename from .vale/fixtures/Localization/Modals/TermsWarnings/testinvalid.adoc rename to .vale/fixtures/Localization/Modals/testinvalid.adoc diff --git a/.vale/fixtures/Localization/Modals/TermsWarnings/testvalid.adoc b/.vale/fixtures/Localization/Modals/testvalid.adoc similarity index 100% rename from .vale/fixtures/Localization/Modals/TermsWarnings/testvalid.adoc rename to .vale/fixtures/Localization/Modals/testvalid.adoc diff --git a/.vale/fixtures/Localization/Modals/TermsWarnings/.vale.ini b/.vale/fixtures/Localization/WordswithMultipleMeanings/.vale.ini similarity index 57% rename from .vale/fixtures/Localization/Modals/TermsWarnings/.vale.ini rename to .vale/fixtures/Localization/WordswithMultipleMeanings/.vale.ini index da0c8aa..070abe1 100644 --- a/.vale/fixtures/Localization/Modals/TermsWarnings/.vale.ini +++ b/.vale/fixtures/Localization/WordswithMultipleMeanings/.vale.ini @@ -1,4 +1,4 @@ -; Vale configuration file to test the `TermsWarnings` rule +; Vale configuration file to test the `WordswithMultipleMeanings` rule StylesPath = ../../../styles MinAlertLevel = warning [*.adoc] diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/.vale.ini b/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/.vale.ini deleted file mode 100644 index d519f8e..0000000 --- a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/.vale.ini +++ /dev/null @@ -1,5 +0,0 @@ -; Vale configuration file to test the `TermsErrors` rule -StylesPath = ../../../styles -MinAlertLevel = suggestion -[*.adoc] -Localization.TermsErrors = YES diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/testinvalid.adoc b/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/testinvalid.adoc deleted file mode 100644 index 80f6b6a..0000000 --- a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/testinvalid.adoc +++ /dev/null @@ -1,6 +0,0 @@ -// Example entries: -// 10BASET -// 24/7 -// a lot -// a number of -// abort diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/testvalid.adoc b/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/testvalid.adoc deleted file mode 100644 index 2b837f3..0000000 --- a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsErrors/testvalid.adoc +++ /dev/null @@ -1,8 +0,0 @@ -// Example entries: -// /etc -// /etc/ -// 10BASE-T -// 10BASE2 -// 12.00 AM -// 24x7 -// a or b diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/.vale.ini b/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/.vale.ini deleted file mode 100644 index 74095b3..0000000 --- a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/.vale.ini +++ /dev/null @@ -1,5 +0,0 @@ -; Vale configuration file to test the `TermsSuggestions` rule -StylesPath = ../../../styles -MinAlertLevel = suggestion -[*.adoc] -Localization.TermsSuggestions = YES diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/testinvalid.adoc b/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/testinvalid.adoc deleted file mode 100644 index 915b9a0..0000000 --- a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/testinvalid.adoc +++ /dev/null @@ -1,5 +0,0 @@ -// Example entries: -// above -// afterwards -// all caps -// bare metal clusters diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/testvalid.adoc b/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/testvalid.adoc deleted file mode 100644 index b2c3c35..0000000 --- a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsSuggestions/testvalid.adoc +++ /dev/null @@ -1,5 +0,0 @@ -// Example entries: -// 64-bit x86 -// bare-metal clusters -// bare-metal compute -// bare-metal configuration diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsWarnings/testinvalid.adoc b/.vale/fixtures/Localization/WordswithMultipleMeanings/testinvalid.adoc similarity index 100% rename from .vale/fixtures/Localization/WordswithMultipleMeanings/TermsWarnings/testinvalid.adoc rename to .vale/fixtures/Localization/WordswithMultipleMeanings/testinvalid.adoc diff --git a/.vale/fixtures/Localization/WordswithMultipleMeanings/TermsWarnings/testvalid.adoc b/.vale/fixtures/Localization/WordswithMultipleMeanings/testvalid.adoc similarity index 100% rename from .vale/fixtures/Localization/WordswithMultipleMeanings/TermsWarnings/testvalid.adoc rename to .vale/fixtures/Localization/WordswithMultipleMeanings/testvalid.adoc diff --git a/.vale/styles/Localization/CommonlyMisusedWords/TermsWarnings.yml b/.vale/styles/Localization/CommonlyMisusedWords.yml similarity index 77% rename from .vale/styles/Localization/CommonlyMisusedWords/TermsWarnings.yml rename to .vale/styles/Localization/CommonlyMisusedWords.yml index d0b20ee..8f72c30 100644 --- a/.vale/styles/Localization/CommonlyMisusedWords/TermsWarnings.yml +++ b/.vale/styles/Localization/CommonlyMisusedWords.yml @@ -8,13 +8,3 @@ message: "Avoid terms that are ambiguous and problematic in a localization conte tokens: - allow - acronym - - etc - - ie - - eg - - ex - - via - - versus - - et cetera - - per se - - vice versa - - won’t diff --git a/.vale/styles/Localization/CommonlyMisusedWords/TermsErrors.yml b/.vale/styles/Localization/CommonlyMisusedWords/TermsErrors.yml deleted file mode 100644 index f834dd3..0000000 --- a/.vale/styles/Localization/CommonlyMisusedWords/TermsErrors.yml +++ /dev/null @@ -1,15 +0,0 @@ ---- -extends: substitution -ignorecase: true -level: error -link: https://redhat-documentation.github.io/vale-at-red-hat/docs/main/reference-guide/termserrors/ -message: "Use '%s' rather than '%s'." -action: - name: replace -# swap maps tokens in form of bad: good -swap: -# Example entries - # "(?