Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in Progress when a Section has no Pages #977

Closed
MyPyDavid opened this issue Apr 22, 2024 · 0 comments · Fixed by #978
Closed

bug in Progress when a Section has no Pages #977

MyPyDavid opened this issue Apr 22, 2024 · 0 comments · Fixed by #978
Assignees
@MyPyDavid
Labels
type:bug
Milestone
RDMO 2.2.0

Comments

@MyPyDavid
Copy link
Member

MyPyDavid commented Apr 22, 2024 •
edited
Loading

Description / Beschreibung

When creating a Catalog where the Sections have no Pages (yet) a bug in the Project progress calculation arises and shows a 500 error.

Expected behaviour / Erwartetes Verhalten

no error

Steps to reproduce / Schritte zum Reproduzieren

  1. Create Catalog, Sections without Pages
  2. Click on Project > Answer Questions
  3. See error

Context / Kontext

Version 2.1.3

References / Verweise

File ".../rdmo/projects/progress.py", line 56, in compute_navigation
'first': catalog_section.elements[0].id if section.elements else None
IndexError: list index out of range
@MyPyDavid MyPyDavid added this to the RDMO 2.2.0 milestone Apr 22, 2024
@MyPyDavid MyPyDavid self-assigned this Apr 22, 2024
MyPyDavid added a commit that referenced this issue Apr 22, 2024
@MyPyDavid
fix: rename to catalog_section #977
ac615db 
Signed-off-by: David Wallace <[email protected]>
MyPyDavid added a commit that referenced this issue Apr 22, 2024
@MyPyDavid
tests: add initial tests for project navigation #977
74949f4 
Signed-off-by: David Wallace <[email protected]>
@MyPyDavid MyPyDavid mentioned this issue Apr 22, 2024
Merged
14 tasks
@MyPyDavid MyPyDavid linked a pull request Apr 22, 2024 that will close this issue
977 bug in progress when a section has no pages #978
Merged
14 tasks
MyPyDavid added a commit that referenced this issue May 14, 2024
@MyPyDavid
fix: rename to catalog_section #977
cf6f4dc 
Signed-off-by: David Wallace <[email protected]>
MyPyDavid added a commit that referenced this issue May 14, 2024
@MyPyDavid
tests: add initial tests for project navigation #977
47a504e 
Signed-off-by: David Wallace <[email protected]>
MyPyDavid added a commit that referenced this issue Jun 19, 2024
@MyPyDavid
fix: rename to catalog_section #977
8d20c88 
Signed-off-by: David Wallace <[email protected]>
MyPyDavid added a commit that referenced this issue Jun 19, 2024
@MyPyDavid
tests: add initial tests for project navigation #977
3924245 
Signed-off-by: David Wallace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MyPyDavid MyPyDavid

Labels
type:bug
Projects
None yet
Milestone
RDMO 2.2.0
Development

Successfully merging a pull request may close this issue.

977 bug in progress when a section has no pages rdmorganiser/rdmo
2 participants
@jochenklar @MyPyDavid