Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review dev changes #197

Open
Danack opened this issue Apr 20, 2023 · 2 comments
Open

Review dev changes #197

Danack opened this issue Apr 20, 2023 · 2 comments
Milestone
2.0

Comments

@Danack
Copy link
Collaborator

Danack commented Apr 20, 2023

Before I merge dev to master, does anyone care to review the changes?

I don't think I broke anything, but it would be nice to get someone else to check.
@Danack Danack added this to the 2.0 milestone Apr 20, 2023
@kelunik
Copy link
Collaborator

kelunik commented Apr 20, 2023

I can do that, but probably rather in two weeks than next week. Could you open a PR for the review?

@Danack
Copy link
Collaborator Author

Danack commented Apr 20, 2023

Review is opened.

but probably rather in two weeks than next week

Cool. Probably going to take that long for people to think about separating the contexts and maybe [soft deprecating the args ]#196) anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@Danack @kelunik