You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for your continuing work on this plugin and merging in my changes from PR #10.
I am working on some changes to add returning translations for taxonomies in the same way we do for posts. While working on this functionality, it struck me that the plugin is getting pretty large. Would you be open to a PR that restructures a bit?
I'm thinking something like this:
Class-based with a namespace - wrap all of the functions in a namespaced class, which would shorten the function names considerably
Main class as a singleton - use the singleton pattern to initialize the plugin and maintain a single instance
Multiple files - break out the functionality related to new types, fields, menus, posts, and taxonomies (and other) into new files - that would help us find and manage the additions and changes a little easier. In other words, organize the plugin code around the core objects being used/impacted.
Remove commented code - given that we are using Git we can safely remove commented code
Add a little more documentation to functions - I don't have all the information for what the functions do but I can add documentation for those that I understand 😁
Overall, I am getting a strong pull to re organize things and figured I would ask before taking the time to do it.
Thanks again!
Don
The text was updated successfully, but these errors were encountered:
As long as it doesn't break anything I am totally open for making the code better.
As you observed this was initially cobbled together and then grew from there.
My main focus was to solve my problem and I simply didn't have the time to structure the code better.
Hello @rburgst,
Thanks for your continuing work on this plugin and merging in my changes from PR #10.
I am working on some changes to add returning translations for taxonomies in the same way we do for posts. While working on this functionality, it struck me that the plugin is getting pretty large. Would you be open to a PR that restructures a bit?
I'm thinking something like this:
Overall, I am getting a strong pull to re organize things and figured I would ask before taking the time to do it.
Thanks again!
Don
The text was updated successfully, but these errors were encountered: