Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: --exclude-private-hosts #28

Open
tamalsaha opened this issue Oct 31, 2019 · 1 comment
Open

Feature request: --exclude-private-hosts #28

tamalsaha opened this issue Oct 31, 2019 · 1 comment

Comments

@tamalsaha
Copy link

tamalsaha commented Oct 31, 2019

Thanks for this tool. We are using this tool with Github actions to make sure our docs don't have invalid urls.

One of the common pattern for us is that our docs have localhost addresses and domains with non-public TLD. Currently I am using --exclude pattern to skip those. But this making the --exclude pattern very long and hard to read. I think it will be very handy to add a --exclude-private-hosts to avoid private domains and private ips.

If you are open to this, I can send a pr.

@tamalsaha tamalsaha changed the title Feature request: --ignore-private-urls Feature request: --exclude-private-hosts Oct 31, 2019
@tamalsaha
Copy link
Author

I have opened a pr #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant