Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] RP2350 datasheet, PIO pseudocode in 11.5.4.1. Autopush Details is wrong #436

Open
naoppy opened this issue Dec 23, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation pdf pio A query about PIO. rp2040 Concerning the RP2040 chip rp2350 Concerning the RP2350 chip

Comments

@naoppy
Copy link

naoppy commented Dec 23, 2024

RP2350 datasheet: https://datasheets.raspberrypi.com/rp2350/rp2350-datasheet.pdf
On p904, Section 11.5.4.1. Autopush Details
sample code says

 1 isr = shift_in(isr, input())
 2 isr count = saturate(isr count + in count)
 3
 4 if rx count >= threshold:
 5   if rx fifo is full:
 6     stall
 7   else:
 8     push(isr)
 9     isr = 0
10     isr count = 0

But I think line 4 should be 4 if isr count >= threshold:.
I'm not an expert of pico, so I might be wrong.

@naoppy
Copy link
Author

naoppy commented Dec 23, 2024

I found 1 more typo.
p905, last line, says "PULL does not require similar behaviour, because autopush does not have the same nondeterminism."
But it should be "PUSH does not require similar behaviour, because autopush does not have the same nondeterminism."

@lurch
Copy link
Contributor

lurch commented Dec 23, 2024

RP2350 datasheet: https://datasheets.raspberrypi.com/rp2350/rp2350-datasheet.pdf On p904, Section 11.5.4.1. Autopush Details sample code says

 1 isr = shift_in(isr, input())
 2 isr count = saturate(isr count + in count)
 3
 4 if rx count >= threshold:
 5   if rx fifo is full:
 6     stall
 7   else:
 8     push(isr)
 9     isr = 0
10     isr count = 0

But I think line 4 should be 4 if isr count >= threshold:. I'm not an expert of pico, so I might be wrong.

I also don't know enough about PIO to know if this is an error or not. But if it is wrong, the same mistake is present in section 3.5.4.1. of the RP2040 datasheet.

@lurch lurch added documentation Improvements or additions to documentation rp2040 Concerning the RP2040 chip pio A query about PIO. pdf rp2350 Concerning the RP2350 chip labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pdf pio A query about PIO. rp2040 Concerning the RP2040 chip rp2350 Concerning the RP2350 chip
Projects
None yet
Development

No branches or pull requests

2 participants