Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i36: Updates package to work with socket.io v4 #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

i36: Updates package to work with socket.io v4 #37

wants to merge 2 commits into from

Conversation

robgonnella
Copy link

  • Replaces checked in mspack_pack.php with rybakit/msgpack composer
    package
  • Adds UID to packed message
  • Removes "#emitter" suffix on key

fixes #36

Rob Gonnella added 2 commits August 18, 2022 02:33
i36: Updates package to work with socket.io v4
2db3c42 
- Replaces checked in mspack_pack.php with rybakit/msgpack composer
  package
- Adds UID to packed message
- Removes "#emitter" suffix on key

fixes rase-#36
Fixes issue with setting namespace, key, and message prefix
089731e
@Tommuh
Copy link

Tommuh commented Nov 16, 2022

Thanks I used this library and your modifications as inspiration!

@rayyzhong
Copy link

is this working with latest socket.io? (now it should be v4.6.1)

@robgonnella
Copy link
Author

@rayyzhong I haven't tried on v4.6.1 yet, want to give it a go and report back? I've pushed my changes to the master branch of my fork here: https://github.com/robgonnella/socket.io-php-emitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Still alive?
3 participants
@robgonnella @Tommuh @rayyzhong