Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Refactoring of dynamic batching implementation details #511

Open
achirkin opened this issue Dec 4, 2024 · 0 comments
Open

[ENH] Refactoring of dynamic batching implementation details #511

achirkin opened this issue Dec 4, 2024 · 0 comments
Assignees
@achirkin
Labels
bug Something isn't working

Comments

@achirkin
Copy link
Contributor

achirkin commented Dec 4, 2024

Consider refactoring cpp/src/neighbors/detail/dynamic_batching.cuh to have more separation between the batch runner class and the queue type by encapsulating commit and wait logic in the queue.

Originally posted by @tfeher in #261 (comment) #261 (comment) #261 (comment)
@achirkin achirkin added the bug Something isn't working label Dec 4, 2024
@achirkin achirkin self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achirkin achirkin

Labels
bug Something isn't working
Projects
VS/ML/DM Primitives Release Board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achirkin