Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reuse C API parameter structs in C++ #487

Open
ajit283 opened this issue Nov 21, 2024 · 0 comments
Open

[BUG] Reuse C API parameter structs in C++ #487

ajit283 opened this issue Nov 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ajit283
Copy link
Contributor

ajit283 commented Nov 21, 2024

We should use the C parameters structs in C++, e.g. using cuvsCagraExtendParams instead of cuvs::neighbors::cagra::extend_params, since having parallel objects like this increases the maintenance burden. An example where this is already done:

using DistanceType = cuvsDistanceType;

@ajit283 ajit283 added the bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant