Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if using cri-dockerd v0.3.5 removes the need for forked kubelet #3409

Closed
superseb opened this issue Oct 12, 2023 · 4 comments
Closed

Test if using cri-dockerd v0.3.5 removes the need for forked kubelet #3409

superseb opened this issue Oct 12, 2023 · 4 comments

Comments

@superseb
Copy link
Contributor

As described in https://github.com/rancher/hyperkube#kubelet-binary-source-change, we are currently using a forked repository to generate the kubelet to solve this issue (rancher/rancher#38816).

It was filed upstream earlier, but it seems that in v0.3.5, a PR was merged to solve this issue.

We should test if using upstream kubelet binary and cri-dockerd v0.3.5 solves the issue so we can remove the need for our fork.

@kinarashah
Copy link
Member

Process wise, we would introduce a new k8s version in KDM (dev branch or forked, would need a new rke-tools branch if not using forked repo) that uses new cri-dockerd, and run the following tests: rancher/rancher#38816 (comment)
rancher/rancher#38816 (comment)

Note that the PR in cri-dockerd is new code change and doesn't fallback to the old behavior, so the performance won't be exactly identical but should be better than the original v1.24.10-rancher1-1 where the issue was first reported. We can compare metrics and then decide if we can rid of the forked kubelet or temporarily deliver both k8s versions (with and without forked kubelet) for users to test it out.

Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@kinarashah
Copy link
Member

Commenting for bot

Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants