-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beat Saber Cannot be Modded due to WindHawk interfering with IPA.exe #358
Comments
Hi, are you the author of IPA.exe? Can you reduce the issue to a small package that can be used to reproduce the problem? For example, attach the original or modified IPA.exe along with winhttp.dll and tell me how to run it to see the problem. |
Hello, I am the maintainer of BSIPA. We've had people complaining recently that the mod loader couldn't be installed, and this error was showing up. I asked them to send a minidump and I noticed that Here's the minidump file: https://pixeldrain.com/u/canuNJQY Somehow the first report we've got about this issue happened way after the latest release you made, only about a month ago. And I didn't make any BSIPA release either in that timeframe, so I assume that it has something to do with system updates or Windhawk mods updates. I can't guarantee that it wasn't an issue before, but we didn't get a single report of it, and now we suddenly get a lot of them. BSIPA uses an old customized version of the Unity doorstop to inject the game and install mods. You can get the latest release of BSIPA here. It'll only work with a game made with Unity. Extract it into the game folder and run Worth noting that some people also started to experience the same issue because of adwares, and it wasn't an issue either before as far as I know. |
Can it be reproduced without having a game installed? |
IPA won't work without a game, but I assume that any console program trying to mess up with this file would be enough to reproduce. I'll see if I can get you a repro case. |
It'd be surprising if having winhttp.dll loaded affected moving a file of the same name. My best guess of how it can cause issues is that perhaps IPA loads its own winhttp.dll and does something like What I can do to mitigate the issue to have winhttp.dll delay-loaded. It's not used that often and it makes sense to do it to reduce the chance of conflicts, although if it does get loaded, the same issue will occur, so it's not a complete fix. |
Indeed it does, as can be seen in the dump.
|
It does load it, but only because of the Windhawk DLL being injected into it. It doesn't otherwise. Here's a dump when Windhawk isn't running: https://send.vis.ee/download/1731f18802f70748/#DIsIh4Qv0mqh-RmDGhXZyA |
OK, now I understand the issue better. winhttp.dll isn't in the list of known DLLs, so it's loaded from the current directory, at which point it's in use so it can't be deleted. Perhaps I can use delay loading together with a custom handler to load the system32 version specifically. I'll see what I can do. |
Not loading the DLL from the current directory would indeed solve the issue. However, I'm still flabbergasted that it didn't happen before considering that you are injecting all programs on purpose (at least from what I've understood of your blog post). I really wonder why. |
We already know beat saber can be modded by putting IPA.exe in the exclusion list, as I said when I first created the post, we just want to know if it can be fixed or not. |
@IAMDEDJUSTTOGETFILES Have you tried putting IPA.exe in the exclusions list of windhawk? |
Yes, as I have said before. I am going to say before you commit on issues, you should read the issue itself first. Mindlessly replying without reading leads you to miss Info that I have already said. Thank you. |
Hello,
BSMG Support here. There's apparently an issue with WindHawk and BSIPA, our modloader for the pc version of the game, in which IPA.exe apparently tries to modify the necessary files, but when it tries to modify winhttp.dll, the permission is denied as seen in the attached image due to WindHawk.
The issue can be fixed by putting IPA.exe in the process exclusions list or by deleting/removing WindHawk. Has this issue come up before? I'll try to get log files or anything you need to debug this.
The text was updated successfully, but these errors were encountered: