From ecea3736b700e4b0dda0cc312bd0c232e497da46 Mon Sep 17 00:00:00 2001
From: Anikesh Suresh <sureshanikesh@yahoo.co.uk>
Date: Thu, 23 Jan 2025 14:53:22 +0000
Subject: [PATCH] Address PR Review Changes #93

---
 object_storage_api/services/image.py | 2 +-
 object_storage_api/stores/image.py   | 6 +++---
 test/unit/repositories/test_image.py | 5 +----
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/object_storage_api/services/image.py b/object_storage_api/services/image.py
index da95074..546fe33 100644
--- a/object_storage_api/services/image.py
+++ b/object_storage_api/services/image.py
@@ -88,7 +88,7 @@ def get(self, image_id: str) -> ImageSchema:
         :return: An image's metadata with its presigned get urls.
         """
         image = self._image_repository.get(image_id=image_id)
-        (view_url, download_url) = self._image_store.create_presigned_get(image)
+        view_url, download_url = self._image_store.create_presigned_get(image)
         return ImageSchema(**image.model_dump(), view_url=view_url, download_url=download_url)
 
     def list(self, entity_id: Optional[str] = None, primary: Optional[bool] = None) -> list[ImageMetadataSchema]:
diff --git a/object_storage_api/stores/image.py b/object_storage_api/stores/image.py
index 9821844..577c0c7 100644
--- a/object_storage_api/stores/image.py
+++ b/object_storage_api/stores/image.py
@@ -58,9 +58,9 @@ def create_presigned_get(self, image: ImageOut) -> tuple[str, str]:
             "ExpiresIn": object_storage_config.presigned_url_expiry_seconds,
         }
 
-        view_response = s3_client.generate_presigned_url(**parameters)
+        view_url = s3_client.generate_presigned_url(**parameters)
 
-        attachment_response = s3_client.generate_presigned_url(
+        download_url = s3_client.generate_presigned_url(
             **{
                 **parameters,
                 "Params": {
@@ -70,7 +70,7 @@ def create_presigned_get(self, image: ImageOut) -> tuple[str, str]:
             }
         )
 
-        return (view_response, attachment_response)
+        return view_url, download_url
 
     def delete(self, object_key: str) -> None:
         """
diff --git a/test/unit/repositories/test_image.py b/test/unit/repositories/test_image.py
index 4fe459e..92545dd 100644
--- a/test/unit/repositories/test_image.py
+++ b/test/unit/repositories/test_image.py
@@ -299,10 +299,7 @@ def set_update_data(self, new_image_in_data: dict):
         """
         self._image_in = ImageIn(**new_image_in_data)
 
-    def mock_update(
-        self,
-        new_image_in_data: dict,
-    ) -> None:
+    def mock_update(self, new_image_in_data: dict) -> None:
         """
         Mocks database methods appropriately to test the `update` repo method.