Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data generator script doesn't return stable DataPublication dates #444

Closed
1 task
louise-davies opened this issue Aug 22, 2023 · 0 comments · Fixed by #447
Closed
1 task

Data generator script doesn't return stable DataPublication dates #444

louise-davies opened this issue Aug 22, 2023 · 0 comments · Fixed by #447
Assignees

Comments

@louise-davies
Copy link
Member

Description:
The icat_db_generator.py script passes the -15y start date variable to DataPublication publication dates and to DataPublicationDates. The problem then is that given the same seed on different days, the data will be off by the difference between the two days. This causes problems with generating data for e2e tests.

Acceptance criteria:

  • DataPublication publicationDate and DataPublicationDates no longer defined relatively, and are instead defined in a way that is fully reproducible with the same seed no matter the date the script is ran
@MRichards99 MRichards99 self-assigned this Aug 30, 2023
MRichards99 added a commit that referenced this issue Aug 30, 2023
- This should stop relative generation causing different data to be generated on different days
MRichards99 added a commit that referenced this issue Aug 30, 2023
- This should stop relative generation causing different data to be generated on different days
MRichards99 added a commit that referenced this issue Aug 30, 2023
- This should stop relative generation causing different data to be generated on different days
MRichards99 added a commit that referenced this issue Sep 6, 2023
MRichards99 added a commit that referenced this issue Sep 7, 2023
…ates-#444

 fix: #444 Generate publication dates between two specific dates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants