Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded ISIS specific endpoints #432

Closed
1 task
louise-davies opened this issue Jun 9, 2023 · 0 comments · Fixed by #448
Closed
1 task

Remove unneeded ISIS specific endpoints #432

louise-davies opened this issue Jun 9, 2023 · 0 comments · Fixed by #448
Assignees
@MRichards99
Labels
db backend Issues relating to the DB backend icat backend Issues relating to the Python ICAT backend

Comments

@louise-davies
Copy link
Member

Description:
Since the InvestigationFacilityCycle relation was added in ICAT 5, ISIS has now implemented that relation in their ICAT and we now no longer use the ISIS specific endpoints to get the list of facility cycles and investigations in those cycles (see ral-facilities/datagateway#1415). Since these endpoints are no longer needed, the datagateway-api codebase can be tidied up by removing them and any auxiliary code that was put in to support them.

Acceptance criteria:

  • ISIS-specific hardcoded endpoints are removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MRichards99 MRichards99

Labels
db backend Issues relating to the DB backend icat backend Issues relating to the Python ICAT backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Remove code and references to ISIS specific table endpoints ral-facilities/datagateway-api
2 participants
@louise-davies @MRichards99