24 hrs format not working properly

[ilahir]

Hi,
24 hrs format not working properly in end hours (55 mins like that)

For Ex : current time is 5:55 PM

show time picker 18:55 like that

[rajeshwarpatlolla]

Can you show me the steps to reproduce this issue?

[ilahir]

Hi,
Please change the system time (For Ex : 10:50 PM)

http://rajeshwarpatlolla.github.io/TimePickerForIonicFramework/demo/#/tab/timepicker

see below image
System time is 10:46 PM
Open your demo time picker and see the time in 24 format (show 23:45 this wrong ---> correct time is 22:45)

[ilahir]

Hi,
Fixed above issues in 24 hrs format

added parseInt, see below code

function o(i, e) {
r.time.hours =parseInt(i / 3600);
var t = i % 3600;
12 == e && (r.time.hours > 12 ? (r.time.hours -= 12, r.time.meridian = "PM") : r.time.meridian = "AM"), r.time.minutes = t / 60, r.time.hours = r.time.hours.toFixed(0), r.time.minutes = r.time.minutes.toFixed(0), 1 == r.time.hours.toString().length && (r.time.hours = "0" + r.time.hours), 1 == r.time.minutes.toString().length && (r.time.minutes = "0" + r.time.minutes), r.time.format = r.mainObj.format
}

[jyotigupta007]

Hi,

I am also facing the same issue. 24 hrs format not working properly in end hours like after 30 minutes it shows 1 hour more in time picker.

[ilahir]

Hi, I fixed this issue

…

On Wed, Dec 28, 2016 at 6:14 PM, jyotigupta007 ***@***.***> wrote: Hi, I am also facing the same issue. 24 hrs format not working properly in end hours like after 30 minutes it shows 1 hour more in time picker. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#101 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE19_N5k55Ey0TIB_Cdt05Crx1RK67TMks5rMlmugaJpZM4KP5ES> .

-- Regards A.ILAHIR RAHMAN ALI Mobile No : +91 9025048816

[jyotigupta007]

Hi Ilahir,

I have changed in min file as you have mentioned in your above comment. And it is working fine.

Thanks for your help.

[rajeshwarpatlolla]

Can someone make a PR with the fix?