Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redundant messaging #26

Open
Dieterbe opened this issue Sep 11, 2015 · 3 comments
Open

redundant messaging #26

Dieterbe opened this issue Sep 11, 2015 · 3 comments

Comments

@Dieterbe
Copy link
Contributor

event-redundant

first message looks good to me,
but the second doesn't have to be anything more than dns OK. the colon and all 3 words after are all redundant.

in other words I think

<monitortype> <status>
<monitortype> <status>: <error message>

is all that is needed
@Dieterbe
Copy link
Contributor Author

@mattttt what do you think?

@Dieterbe
Copy link
Contributor Author

also, should we make these messages look as much like the subjects of our alert emails as possible?

@mattttt
Copy link
Contributor

mattttt commented Aug 10, 2016

I agree that the "Monitor now OK" is redundant. Are there any situations where an OK message will include any other text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dieterbe @mattttt