-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade generator #218
Comments
Hi folks! |
Thanks @KoolTheba! I asigned you the tasks you requested |
- Related ragingwind#218 - ES6 refactor for `test-manifest` - Remove unused callbacks in test - Reduce test redundancy
- Related ragingwind#218 - ES6 refactor for `test-generator` - `pkgContainsDevDependencies` has been removed
- Related ragingwind#218 - ES6 refactor for `test-extension`
- Related ragingwind#218 - ES6 refactor for `helper` - Removed dependency `object-assign`
* WIP.Test refactor - Related #218 - ES6 refactor for `test-manifest` - Remove unused callbacks in test - Reduce test redundancy * WIP.Test refactor - Related #218 - ES6 refactor for `test-generator` - `pkgContainsDevDependencies` has been removed * WIP.Test refactor - Related #218 - ES6 refactor for `test-extension` * Test refactor - Related #218 - ES6 refactor for `helper` - Removed dependency `object-assign`
TLDR: Generated extensions will work but Chrome webstore will not approve the generated extensions. A lot of things have changed over the past few years. Chrome webstore now doesn't approve extension with bundler generated/obfuscated code. So we may have to drop babel, gulp, bower, uglify etc. Also, this generator was built a long time ago when Chrome was on ES5. But now Chrome supports ES6+ and modules. So we can safely drop some dependencies as well. |
Here is the related snippet from Developer Program Policies
|
* WIP.Test refactor - Related #218 - ES6 refactor for `test-manifest` - Remove unused callbacks in test - Reduce test redundancy * WIP.Test refactor - Related #218 - ES6 refactor for `test-generator` - `pkgContainsDevDependencies` has been removed * WIP.Test refactor - Related #218 - ES6 refactor for `test-extension` * Test refactor - Related #218 - ES6 refactor for `helper` - Removed dependency `object-assign` Co-authored-by: Theba Gomez <[email protected]>
We can upgrade the generator a little bit 💪 💪
Important!
development
. Please point the PRs to that branchAsigned tasks
Migrate to ES6+(lead @KoolTheba) Tests migrated to ES6 #240 Tests migrated to ES6 #219yeoman-generator
to ^4.2.0. Major code change (lead @KoolTheba)Some ideas (free to pick):
yeoman-test
to 2.0.0yeoman-assert
to ^3.1.1generator-jasmine
to ^2.0.1generator-mocha
to ^2.0.3🚀 More ideas are super welcome!.
This issue is great for newcomers and first contributions, so... don't be shy and let us know if you want to help us 😉
The text was updated successfully, but these errors were encountered: