Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade generator #218

Open
1 of 7 tasks
UlisesGascon opened this issue Nov 1, 2019 · 4 comments
Open
1 of 7 tasks

Upgrade generator #218

UlisesGascon opened this issue Nov 1, 2019 · 4 comments

Comments

@UlisesGascon
Copy link
Contributor

UlisesGascon commented Nov 1, 2019

We can upgrade the generator a little bit 💪 💪

Important!

  • The current working branch for this job is development. Please point the PRs to that branch

Asigned tasks

Some ideas (free to pick):

  • Reduce support for lower Nodejs versions (I suggest to support from v10 (included))
  • Upgrade dependency yeoman-test to 2.0.0
  • Upgrade dependency yeoman-assert to ^3.1.1
  • Upgrade dependency generator-jasmine to ^2.0.1
  • Upgrade dependency generator-mocha to ^2.0.3

🚀 More ideas are super welcome!.

This issue is great for newcomers and first contributions, so... don't be shy and let us know if you want to help us 😉

@KoolTheba
Copy link
Contributor

Hi folks!
I'd love to help with this issue. I can take care of the ES6 migration and the upgrade dependency for Yeoman generator.

@UlisesGascon
Copy link
Contributor Author

Thanks @KoolTheba! I asigned you the tasks you requested

@UlisesGascon UlisesGascon pinned this issue Nov 3, 2019
KoolTheba added a commit to KoolTheba/generator-chrome-extension that referenced this issue Nov 24, 2019
- Related ragingwind#218
- ES6 refactor for `test-manifest`
- Remove unused callbacks in test
- Reduce test redundancy
KoolTheba added a commit to KoolTheba/generator-chrome-extension that referenced this issue Nov 24, 2019
- Related ragingwind#218
- ES6 refactor for `test-generator`
- `pkgContainsDevDependencies` has been removed
KoolTheba added a commit to KoolTheba/generator-chrome-extension that referenced this issue Nov 24, 2019
- Related ragingwind#218
- ES6 refactor for `test-extension`
KoolTheba added a commit to KoolTheba/generator-chrome-extension that referenced this issue Nov 24, 2019
- Related ragingwind#218
- ES6 refactor for `helper`
- Removed dependency `object-assign`
UlisesGascon pushed a commit that referenced this issue Nov 24, 2019
* WIP.Test refactor

- Related #218
- ES6 refactor for `test-manifest`
- Remove unused callbacks in test
- Reduce test redundancy

* WIP.Test refactor

- Related #218
- ES6 refactor for `test-generator`
- `pkgContainsDevDependencies` has been removed

* WIP.Test refactor

- Related #218
- ES6 refactor for `test-extension`

* Test refactor

- Related #218
- ES6 refactor for `helper`
- Removed dependency `object-assign`
@HemantPawar
Copy link
Contributor

HemantPawar commented Oct 2, 2020

TLDR: Generated extensions will work but Chrome webstore will not approve the generated extensions.

A lot of things have changed over the past few years.

Chrome webstore now doesn't approve extension with bundler generated/obfuscated code. So we may have to drop babel, gulp, bower, uglify etc.

Also, this generator was built a long time ago when Chrome was on ES5. But now Chrome supports ES6+ and modules. So we can safely drop some dependencies as well.

@HemantPawar
Copy link
Contributor

Here is the related snippet from Developer Program Policies

Code Readability Requirements:
Developers must not obfuscate code or conceal functionality of their extension. 
This also applies to any external code or resource fetched by the extension package. 
Minification is allowed, including the following forms:

- Removal of whitespace, newlines, code comments, and block delimiters
- Shortening of variable and function names
- Collapsing files together

UlisesGascon added a commit that referenced this issue Apr 5, 2022
* WIP.Test refactor

- Related #218
- ES6 refactor for `test-manifest`
- Remove unused callbacks in test
- Reduce test redundancy

* WIP.Test refactor

- Related #218
- ES6 refactor for `test-generator`
- `pkgContainsDevDependencies` has been removed

* WIP.Test refactor

- Related #218
- ES6 refactor for `test-extension`

* Test refactor

- Related #218
- ES6 refactor for `helper`
- Removed dependency `object-assign`

Co-authored-by: Theba Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants