Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update {% with %} syntax #1844

Closed
rafalp opened this issue Jan 22, 2025 · 5 comments
Closed

Update {% with %} syntax #1844

rafalp opened this issue Jan 22, 2025 · 5 comments
Assignees
Labels
area: backend This issue involves Python, Django or dependency (eg. database) area: theme This issue involves HTML and CSS help wanted

Comments

@rafalp
Copy link
Owner

rafalp commented Jan 22, 2025

Django's {% with %} template tag used to have this syntax:

{% with something as other %}

Few versions ago Django introduced new syntax:

{% with other=something %}

We should update Misago's templates to use it.

Also, in few places where we nest with's, we should flatten them:

{% with lorem.ipsum.something as var1 %}
  {% with lorem.ipsum.dolor as var2 %}

To:

{% with var1=lorem.ipsum.something var2=lorem.ipsum.dolor %}
@rafalp rafalp added area: theme This issue involves HTML and CSS help wanted labels Jan 22, 2025
@rafalp rafalp added this to the Next feature release milestone Jan 22, 2025
@paulinek13
Copy link
Contributor

Hi! I’d like to work on this issue 😃
Is it still up for grabs?

@rafalp
Copy link
Owner Author

rafalp commented Feb 1, 2025

It is. I can assign it to you if you want. Also I'll be making one more issue to rename trans and blocktrans to translate and blocktranslate

@rafalp
Copy link
Owner Author

rafalp commented Feb 1, 2025

Rename for i18n tags is now tracked with #1853

@paulinek13
Copy link
Contributor

Yes, please assign both issues to me. I'll work on them together and submit a PR within a day

@rafalp rafalp added the area: backend This issue involves Python, Django or dependency (eg. database) label Feb 2, 2025
@rafalp
Copy link
Owner Author

rafalp commented Feb 2, 2025

Fixed in #1854

@rafalp rafalp closed this as completed Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend This issue involves Python, Django or dependency (eg. database) area: theme This issue involves HTML and CSS help wanted
Projects
None yet
Development

No branches or pull requests

2 participants