Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blank config files #224

Closed
audreylace opened this issue Dec 8, 2023 · 3 comments
Closed

Support blank config files #224

audreylace opened this issue Dec 8, 2023 · 3 comments

Comments

@audreylace
Copy link
Contributor

audreylace commented Dec 8, 2023

I found it odd that radvd considers blank files to be invalid. Main use case for empty files is to allow other services in the system to simply write changes to the configuration file and simply tell radvd reload. Right now they can do this but it requires re-starting radvd as the process quits out.

Suggested changes, do know this would require fixing the poll bug.

Sample changes:
https://github.com/radvd-project/radvd/compare/master...audreylace:radvd-stinput:support-blank-conffile?expand=1

@audreylace
Copy link
Contributor Author

audreylace commented Dec 8, 2023

Few places that invoke scripts that could be used to dynamically change and reload the configuration file:

@robbat2
Copy link
Member

robbat2 commented Dec 9, 2023

Agree on the bug; not sure about your branch, it still exits if the file is empty?

@Neustradamus
Copy link
Member

@audreylace: Have you seen @robbat2 comment?

@audreylace audreylace closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants