Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the automation to upload proper dist tarballs #213

Closed
stappersg opened this issue Nov 20, 2023 · 6 comments · Fixed by #215
Closed

Improve the automation to upload proper dist tarballs #213

stappersg opened this issue Nov 20, 2023 · 6 comments · Fixed by #215

Comments

@stappersg
Copy link
Member

... Separately, we need to improve the automation to upload proper dist tarballs, since the GitHub release system automatically used the tip of the tree, rather than the files I wanted to upload.

Originally posted by @robbat2 in #185 (comment)

@stappersg
Copy link
Member Author

Time will tell what advice was provided.

In others words: Those with ideas about this, are welcome to provide their two cents.

@RICCIARDI-Adrien
Copy link
Contributor

Can you provide more information about what you want to do ?
What kind of files do you want to generate ? Maybe the same files than in the 2.19 release https://github.com/radvd-project/radvd/releases/tag/v2.19 ?

@robbat2
Copy link
Member

robbat2 commented Nov 25, 2023

make dist && make sign -> GitHub Release automation.

@stappersg
Copy link
Member Author

make dist -> GitHub Release automation.

Acknowledge

make sign -> GitHub Release automation.

Please, pretty please, prevent that private key material is needed on GitHub servers.

@robbat2
Copy link
Member

robbat2 commented Nov 26, 2023

See the PR, that's pretty much all I had in mind, gh release covers it.

@stappersg
Copy link
Member Author

See the PR, that's pretty much all I had in mind, gh release covers it.

And with MR #215 there is no need to keep this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants