-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements/build issues for FreeBSD #145
Comments
Both patches lack a why
Out of scope of this issue. |
OK, it will be up to FreeBSD guys to show up if they want to upstream their patches. Are the "check" tests, built and executed with command |
I emailed the author of those patches |
So I did respond in October 2021 a little late but perhaps we want to pick this back up now? |
Where?
There is meanwhile #217 |
Can we not play this game after another 2 years of silence? I got an email, I responded and followed up here. The patch reasons are known and documented and the scope in FreeBSD has also shifted over time. The main question is what is the radvd plan here? |
And #217 simply lacks context. 😉 |
Hi @fichtner I checked my email archives and I don't see any response from you in 2021. Can you please submit cleaned versions of those patches as PRs, with commit message descriptions/signed-off-by DCO statements (It's unclear who wrote the patches). I also see that the first patch does NOT populate the |
Hi @robbat2, This was the message:
The bug we spoke of was found and fixed in FreeBSD this year. opnsense/src@93e9cefd053 There was also an attempt predating this but it only fixed the lesser half of the issue. opnsense/src@3eebc6234b0
patch-interface.c changes were only required to address opnsense/src@93e9cefd053 and superseded by opnsense/src@3eebc6234b0 so I think I can submit a patch to remove this one from FreeBSD. I hope this clears up the questions. Cheers, |
To be clear, I can just move those two functions into opnsense/src@93e9cefd053 explains a lot of the issues. I realize in checking the code, that we've never actually made any statements about which BSD(s) and versions are supported or not. |
Hmm, give me a bit of time to see if
As far as FreeBSD 13.2 and 14.0 are concerned they work ok with the EADDRINUSE safeguard. Older FreeBSD releases are no longer supported anyway.
Well, knowing they can handle additional patching via their ports trees I don't think it's a huge issue going forward with this and if so they might upstream a small ifdef for their operating system, e.g. in the Naturally I don't want to speak for any of the BSDs with OPNsense being a side show, but I think the goal of integrating "BSD" is worth doing and the feedback will trickle in if the integration needs tweaking for a particular BSD. Cheers, |
I've done some testing on this with FreeBSD 14 and the only patch needed to make things work is the changes to
Without this, radvd doesn't respond to router solicitations from clients. Following the discussion above, the other patches don't seem necessary with the changes that have happened in FreeBSD. |
@heliosfa if the patch corresponds to https://github.com/freebsd/freebsd-ports/blob/main/net/radvd/files/patch-device-bsd44.c then that is fine. I will point out that freebsd/freebsd-ports@773d8b58
I suspect that 2.20 will have issues in FreeBSD due to the volume of changes going in, but they can only be addressed when it arrives eventually. Cheers, |
@pandrewhk, @miwi-fbsd, @dhn, @bapt, @rbgarga, @olgeni, @farrokhi, @droso, @mat813, @tcberner, @stesser, @nunotexbsd: What do you think? Thanks in advance. |
@fichtner that's the one. I've been running radvd-2.20-rc1 on pfsense since Feb with no issues. |
Ok nice, shall I offer a PR then? |
No need to call the cavalry -- let me do it this afternoon. :) Cheers, |
@fichtner: In your PR, please add: |
…ct#145 This adds the latest FreeBSD ports code modifications. These went through several iterations over the years due to internal bugs. This code is specific to FreeBSD. Mileage may vary for other BSDs and makes no effort to account for this, but should be trivial to achive if required. Originally submitted by: Geoffrey Sisson <[email protected]>
Done #241 |
implement setup_allrouters_membership() et al for FreeBSD #145
And now closing this issue. In case I was too hasty to close, please make a fresh start (new merge request or new issue) to get the radvd project forward. |
Thanks, will do a bit more QA with the current development state on OPNsense/FreeBSD on Monday just to be sure. Cheers, |
Hi,
We may integrate some FreeBSD upstream patches into next radvd release, like this one : https://github.com/freebsd/freebsd-ports/blob/master/net/radvd/files/patch-device-bsd44.c (I did not try yet to build master radvd with this patch applied, I currently have some autoconf issues with FreeBSD 12).
There is also this patch : https://github.com/freebsd/freebsd-ports/blob/master/net/radvd/files/patch-interface.c.
What do you think about these integrations ?
I will keep this issue updated, I will need help for autotool.
The text was updated successfully, but these errors were encountered: