From c6eb041a3e9d6e6a73b34e6a7598bc61d95e386f Mon Sep 17 00:00:00 2001 From: nithyatsu Date: Wed, 8 Jan 2025 15:00:09 -0800 Subject: [PATCH] remove some comments and add a const. --- pkg/cli/cmd/resourceprovider/create/create.go | 1 - pkg/cli/cmd/resourcetype/create/create.go | 1 - pkg/cli/manifest/registermanifest.go | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/cli/cmd/resourceprovider/create/create.go b/pkg/cli/cmd/resourceprovider/create/create.go index 162bef3c76..97333b0c08 100644 --- a/pkg/cli/cmd/resourceprovider/create/create.go +++ b/pkg/cli/cmd/resourceprovider/create/create.go @@ -136,7 +136,6 @@ func (r *Runner) Run(ctx context.Context) error { return err } - // Add a blank line before printing the result. r.Output.LogInfo("") err = r.Output.WriteFormatted(r.Format, response, common.GetResourceProviderTableFormat()) diff --git a/pkg/cli/cmd/resourcetype/create/create.go b/pkg/cli/cmd/resourcetype/create/create.go index 4826010501..d8a24c3ac0 100644 --- a/pkg/cli/cmd/resourcetype/create/create.go +++ b/pkg/cli/cmd/resourcetype/create/create.go @@ -160,7 +160,6 @@ func (r *Runner) Run(ctx context.Context) error { } } - // Add a blank line before printing the result. r.Output.LogInfo("") err = r.Output.WriteFormatted(r.Format, response, common.GetResourceTypeTableFormat()) diff --git a/pkg/cli/manifest/registermanifest.go b/pkg/cli/manifest/registermanifest.go index 72ad93090c..2c2a54fb72 100644 --- a/pkg/cli/manifest/registermanifest.go +++ b/pkg/cli/manifest/registermanifest.go @@ -195,7 +195,7 @@ func RegisterType(ctx context.Context, clientFactory *v20231001preview.ClientFac var defaultAPIVersion string if resourceType.DefaultAPIVersion == nil { - defaultAPIVersion = "2023-10-01-preview" //hardcoded for now, since we don't have a default API version in the manifest but it should be made mandatory as part of schema validation + defaultAPIVersion = v20231001preview.Version //hardcoded for now, since we don't have a default API version in the manifest but it should be made mandatory as part of schema validation } else { defaultAPIVersion = *resourceType.DefaultAPIVersion }