Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firstlib.R #8

Open
antagomir opened this issue Oct 4, 2019 · 2 comments
Open

firstlib.R #8

antagomir opened this issue Oct 4, 2019 · 2 comments
Assignees

Comments

@antagomir
Copy link
Member

We could collect all importFrom material from the individual R/*.R files into R/firstlib.R (as in e.g. eurostat). This helps to manage all imports in a single place.

@jlehtoma
Copy link
Contributor

jlehtoma commented Oct 4, 2019

For me, listing the imports in the Roxygen-docs just before the function definition helps to quickly find where specific imports are used. Then again I do (almost consistently) use package::function() format, which makes it slightly easier to find specific imports.

Since Roxygen2 collates the imports anyway, is there anything else to be managed (e.g. packages collisions etc)?

@jlehtoma jlehtoma self-assigned this Oct 4, 2019
@antagomir
Copy link
Member Author

Not sure if this makes a big difference in practice. One benefit that I have noticed is that it is easy to see at once which packages are imported, and then keep the DESCRIPTION file imports up-to-date (also removing unnecessary packages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants