Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SocialShare is dependent on sketches-host which will give some unknown bugs #62

Open
asimqt opened this issue Jan 2, 2019 · 0 comments
Open

SocialShare is dependent on sketches-host which will give some unknown bugs #62

asimqt opened this issue Jan 2, 2019 · 0 comments

Comments

@asimqt
Copy link
Contributor

asimqt commented Jan 2, 2019

Component SocialShare is dependent on the config value sketches-host. If the value doesn't accessible at state.qt.config["sketches-host"] normally because dev forget to whitelist that, this will throw invalid link like https://www.facebook.com/sharer.php?u=undefined/corporate-lifestyle/2010/01/01/power-lunch.

TODO:
Make the prop required and fail gracefully if the sketches-host not available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asimqt