Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation of DfpAds #5

Open
asimqt opened this issue Feb 13, 2018 · 0 comments
Open

Update documentation of DfpAds #5

asimqt opened this issue Feb 13, 2018 · 0 comments

Comments

@asimqt
Copy link
Contributor

asimqt commented Feb 13, 2018

Documentation of DfpAds not talking about viewPortSizeMapping which causes the front end to show both mobile and desktop ads in all devices.

const viewPortSizeMappingHorizontal = [ {viewport: [980, 690], sizes:[[728, 90]]},
                              {viewport: [320, 0], sizes:[[320, 50]]},
                              {viewport: [0, 0], sizes:[[320, 50]]}];
export const AD_CONFIG = {
   "Horizontal-Ad": { 
     adUnit: "Madrid_Horizontal_Responsive",
     sizes: [[728, 90], [320, 50]],
     viewPortSizeMapping: viewPortSizeMappingHorizontal
   }
   ...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant