Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HamburgerButton should toggle the state instead of making the state true. #47

Open
asimqt opened this issue Nov 21, 2018 · 0 comments
Open

HamburgerButton should toggle the state instead of making the state true. #47

asimqt opened this issue Nov 21, 2018 · 0 comments

Comments

@asimqt
Copy link
Contributor

asimqt commented Nov 21, 2018

Currently HamburgerButton is only setting the state.hamburgerOpened to true. I think it should toggle the current state. Otherwise, there's no use of this component.
https://github.com/quintype/quintype-node-components/blob/ed36d6f081729d0cfb1b79517bf2c1cac920cac6/src/store/reducers.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asimqt