From cc4fb541952bbb714c800dbde35f33b0d790c975 Mon Sep 17 00:00:00 2001 From: Ralph Filho Date: Fri, 7 Jun 2024 10:35:03 -0300 Subject: [PATCH] fix: tests --- butterfree/pipelines/feature_set_pipeline.py | 2 +- butterfree/transform/utils/function.py | 2 +- .../transform/transformations/test_aggregated_transform.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/butterfree/pipelines/feature_set_pipeline.py b/butterfree/pipelines/feature_set_pipeline.py index 8ff73324..8ba1a636 100644 --- a/butterfree/pipelines/feature_set_pipeline.py +++ b/butterfree/pipelines/feature_set_pipeline.py @@ -136,7 +136,7 @@ def __init__( source: Source, feature_set: FeatureSet, sink: Sink, - spark_client: Optional[SparkClient], + spark_client: Optional[SparkClient] = None, ): self.source = source self.feature_set = feature_set diff --git a/butterfree/transform/utils/function.py b/butterfree/transform/utils/function.py index b2fb918e..951a232c 100644 --- a/butterfree/transform/utils/function.py +++ b/butterfree/transform/utils/function.py @@ -34,7 +34,7 @@ def func(self, value: Callable) -> None: """Definitions to be used in the transformation.""" if value is None: raise ValueError("Function must not be empty.") - if callable(value) is None: + if callable(value) is False: raise TypeError("Function must be callable.") self._func = value diff --git a/tests/unit/butterfree/transform/transformations/test_aggregated_transform.py b/tests/unit/butterfree/transform/transformations/test_aggregated_transform.py index f0ae2f85..96ff682a 100644 --- a/tests/unit/butterfree/transform/transformations/test_aggregated_transform.py +++ b/tests/unit/butterfree/transform/transformations/test_aggregated_transform.py @@ -67,7 +67,7 @@ def test_blank_aggregation(self, feature_set_dataframe): name="feature1", description="unit test", transformation=AggregatedTransform( - functions=[Function(func="", data_type="")] + functions=[Function(func=None, data_type="")] ), )