Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use country flags from the same source #4362

Open
kndehaan opened this issue Oct 30, 2024 · 4 comments
Open

Use country flags from the same source #4362

kndehaan opened this issue Oct 30, 2024 · 4 comments
Assignees

Comments

@kndehaan
Copy link
Contributor

A new source for country flags is used for new country datasets NO, CH, RS: https://flagdownload.com/
A new source is used since we don't know the source from the all ready existing country datasets. Unfortunately it is visible that the layout of the flags are a bit different from the new source.

image

Solution is:

  • to replace all flags with flags from this new source
  • while we're at it, we should add a flag for Singapore
@claudiavalkenier
Copy link
Contributor

I've been checking out other packages (since the ones from https://flagdownload.com/ are not so nice - imo). It's been tricky to find free ones that include all rights, though. Here are a few options (like for Norway):

Although the current ones are way better than these ones, I think we need to replace them all. What do you think?

@claudiavalkenier claudiavalkenier closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
@noracato
Copy link
Member

Hey! I think you can also widen the search if you are unhappy so far, with open source installable flag packs like this one demo. Just make sure they are compatible with yarn and we should be able to install them in etmodel!

@kndehaan
Copy link
Contributor Author

kndehaan commented Dec 10, 2024

Hey! I think you can also widen the search if you are unhappy so far, with open source installable flag packs like this one demo. Just make sure they are compatible with yarn and we should be able to install them in etmodel!

Good suggestion @noracato, I however have no idea how to implement the method of getting the flags via yarn to how we now read the flags saved in etmodel/app/assets/images/flags-24.

  • Does this require a whole new setup in the code? Is this something that we would want? Then this is something where we rely on dev, so then we won't be able to implement this right now...
  • But if you mean with 'installing in etmodel' that we just save all flags from a package into the above mentioned folder in one go (instead of needing other changes in code setup), is this something that @claudiavalkenier or with my support can pick up with some instructions provided by you?

@claudiavalkenier
Copy link
Contributor

Aside from these packages, @noracato do you know whether it is possible to use flags with a .pdf or .svg extension (or some other vector-based extension)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants