Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Length fields missing as prefix to binary fields #693

Open
vanrein opened this issue Feb 16, 2025 · 0 comments
Open

Bugfix: Length fields missing as prefix to binary fields #693

vanrein opened this issue Feb 16, 2025 · 0 comments

Comments

@vanrein
Copy link

vanrein commented Feb 16, 2025

Related to #692 which tries to including binary signatures in the Trailer.

There is support for one length prefix, namely for XML data. The same code can be used for other lenghts, albeit specific to Header, Body, Trailer parts of the message. This was implemented in

https://gitlab.com/arpa2/quickfixgo/-/commit/4606908ab723121b87d3885f0eae15eb2c77d4bc

You are invite to incorporate this into QuickFIX/Go if you think it is helpful. Me being new to the software, I suspect you may have style requirements that I am unaware of, so I will not make a PR unless you think it is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant