Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-lambda guide refers to AWS Java 11 image and mentions Java 8/11 version #45616

Open
rsvoboda opened this issue Jan 15, 2025 · 4 comments · May be fixed by #45721
Open

aws-lambda guide refers to AWS Java 11 image and mentions Java 8/11 version #45616

rsvoboda opened this issue Jan 15, 2025 · 4 comments · May be fixed by #45721

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Jan 15, 2025

Describe the bug

aws-lambda guide refers to AWS Java 11 image and mentions Java 8/11 version

https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/aws-lambda.adoc?plain=1#L629

public.ecr.aws/lambda/java:11

https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/aws-lambda.adoc?plain=1#L639

`java:11` base image from AWS

https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/aws-lambda.adoc?plain=1#L572

NOTE: GraalVM versions can have different paths for these files whether you are using the Java 8 or 11 version. Adjust accordingly.
@rsvoboda rsvoboda added the kind/bug Something isn't working label Jan 15, 2025
Copy link

quarkus-bot bot commented Jan 15, 2025

/cc @matejvasek (amazon-lambda), @patriot1burke (amazon-lambda)

@gsmet gsmet added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Jan 20, 2025
@gsmet
Copy link
Member

gsmet commented Jan 20, 2025

Please let's not make a bug a documentation issue.

@rsvoboda
Copy link
Member Author

To me it's a bug, even though just in the docs. Do you want to use kind/bug just for functional issues?

@gsmet gsmet self-assigned this Jan 20, 2025
@rsvoboda
Copy link
Member Author

Maybe https://github.com/quarkusio/quarkus/issues/new/choose should be adjusted to avoid docs issues landing in bugs.

Text for kind/enhancement in https://github.com/quarkusio/quarkus/issues/new/choose says

Feature request / Enhancement
Request or propose a new feature/enhancement

So it doesn't indicate that people should use it for documentation issues.

Maybe Housekeeping could be used for documentation issues.
But I still need some convincing that kind/bug and area/documentation shouldn't be used together :)

gsmet added a commit to gsmet/quarkus that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants