Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 sync file download doesn't work #1179

Closed
petro1 opened this issue Mar 20, 2024 · 2 comments
Closed

S3 sync file download doesn't work #1179

petro1 opened this issue Mar 20, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@petro1
Copy link

petro1 commented Mar 20, 2024

The issue is that download file method should have byte[] as response content and not String
https://github.com/quarkiverse/quarkus-amazon-services/blob/main/docs/modules/ROOT/pages/amazon-s3.adoc
Replace: ResponseBuilder response = Response.ok(objectBytes.asUtf8String());
With: Response.ResponseBuilder response = Response.ok(objectBytes.asByteArray());

@scrocquesel scrocquesel added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 20, 2024
@scrocquesel
Copy link
Member

Good catch would you like to contribute a PR ? You can also push a PR to the repo containing the source of the quickstart sample https://github.com/quarkusio/quarkus-quickstarts/blob/884beacd8c723877b98587d6ced5eff8c792ac7e/amazon-s3-quickstart/src/main/java/org/acme/s3/S3SyncClientResource.java#L57

@petro1
Copy link
Author

petro1 commented Mar 21, 2024

@scrocquesel thanks for your quick check, I created this PR: quarkusio/quarkus-quickstarts#1400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants