Fix classical conditions getting optimized ahead of their measurements #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6872 +/- ##
==========================================
- Coverage 97.86% 97.86% -0.01%
==========================================
Files 1084 1084
Lines 94225 94234 +9
==========================================
+ Hits 92215 92223 +8
- Misses 2010 2011 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During simulation, classical controlled empty subcircuits were getting put in the "prefix" part of the simulation, while corresponding measurements were put in the suffix, causing these ops to be executed out of order. This was due to the
split_into_matching_protocol_then_generalfunction, which ensured that qubit access order was preserved, but overlooked doing the same for measurement keys. This PR fixes that.Fixes #6730