astyle: Replace sorting implementation

[tygyh]

The following vulnerabilities are fixed with an upgrade:

• https://cwe.mitre.org/data/definitions/125.html
• https://cwe.mitre.org/data/definitions/787.html

Description

Replace the sorting implementation since the previous implementation might cause a buffer overread.

[rouault]

since the previous implementation might cause a buffer overread.

I don't think so. Can you prove it ?
Note that the C standard allows "one-past-the-end pointer", so &fileName[fileName.size()] is legal.
Cf https://stackoverflow.com/questions/16233868/pointer-comparisons-with-one-past-the-last-element-of-an-array-object and https://port70.net/~nsz/c/c11/n1570.html#6.5.6p8

But your proposal looks slightly more elegant

[rouault]

Note that the C standard allows "one-past-the-end pointer", so &fileName[fileName.size()] is legal.

Apologies. On reflection, I'm likely wrong. fileName.data() + fileName.size() would be legal, but here we formally dereference an out-of-range index, before taking its address. So a pedantic analyzer would likely complain about that

[github-actions]

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 52e3d5b)