Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept 2d box extent when estimating metadata #57323

Merged
merged 1 commit into from
May 7, 2024
Merged

Accept 2d box extent when estimating metadata #57323

merged 1 commit into from
May 7, 2024

Conversation

strk
Copy link
Contributor

@strk strk commented May 2, 2024

Fixes GH-56541

I tried the least change fix

@strk strk requested a review from benoitdm-oslandia May 2, 2024 17:28
@github-actions github-actions bot added this to the 3.38.0 milestone May 2, 2024
@strk
Copy link
Contributor Author

strk commented May 2, 2024

It's to be noted that also for PostGIS < 2.0.0 so the problem is not just with "estimated metadata"

@strk strk mentioned this pull request May 2, 2024
Closed
2 tasks
@strk strk added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Data Provider Related to specific vector, raster or mesh data providers Bug Either a bug report, or a bug fix. Let's hope for the latter! labels May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit f5e51e7)

benoitdm-oslandia
benoitdm-oslandia approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@benoitdm-oslandia benoitdm-oslandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and efficient ;)!

@strk
Copy link
Contributor Author

strk commented May 3, 2024

What's the label to add to have this backported to all relevant branches ? We know at least 3.36 is affected.

@strk strk enabled auto-merge (rebase) May 3, 2024 09:35
@Gustry
Copy link
Contributor

Gustry commented May 3, 2024

queued_ltr and release-3_34are redundant. You must choose one or the other.
Are you sure that 3.34 is affected ?

Thanks for the fix @strk

@strk
Copy link
Contributor Author

strk commented May 6, 2024

I did not test 3.4, did you @Komz0 ?

@Gustry
Copy link
Contributor

Gustry commented May 6, 2024

The ticket (and others) were saying 3.36.X.

@strk Your message #56541 (comment) is quoting a commit in 3.36 if I'm not wrong.

@strk
Copy link
Contributor Author

strk commented May 6, 2024

Ok, labels updated. I need a valid approval before this can be merged. @elpaso ?

@strk strk merged commit b3d1848 into qgis:master May 7, 2024
50 checks passed
@qgis-bot qgis-bot mentioned this pull request May 7, 2024
Merged
@strk
Copy link
Contributor Author

strk commented May 8, 2024

Thank you @rouault

@strk strk deleted the fix-estimated-extent branch May 8, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault approved these changes

@benoitdm-oslandia benoitdm-oslandia benoitdm-oslandia approved these changes

Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Requires Tests! Waiting on the submitter to add unit tests before eligible for merging
Projects
None yet
Milestone
3.38.0
Development

Successfully merging this pull request may close these issues.

3.36 PostGIS layers have no spatial extent
4 participants
@strk @Gustry @rouault @benoitdm-oslandia