[expression] Add @map_z_range_{lower,upper} pair of variables reflecting the map's z range values #56679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
approved these changes
Mar 4, 2024
…ing the map's z range values
nirvn
force-pushed
the
mapsettings_zrange_context
branch
from
05638c4 to
489306e
Compare
DelazJ
reviewed
Mar 4, 2024
Comment on lines
528
to
529
| // IMPORTANT: ANY CHANGES HERE ALSO NEED TO BE MADE TO QgsLayoutItemMap::createExpressionContext() | ||
| // (rationale is described in QgsLayoutItemMap::createExpressionContext() ) |
There was a problem hiding this comment.
@nirvn should then not be some changes in QgsLayoutItemMap::createExpressionContext() also? Or this block should have been moved instead of copied?
There was a problem hiding this comment.
@DelazJ , that was taken care of by @nyalldawson in a different PR.
There was a problem hiding this comment.
Ah. Great! Sorry for the noise.
zacharlie
added
the
Changelog
|
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
zacharlie
added
ChangelogHarvested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@nyalldawson , your work massively improving Z range filtering support is inspiring 😉 this PR adds a pair of @map_z_range_{lower,upper} variables to reflect the map canvas' z range value, which allows us to do stuff like:
Screencast.from.2024-03-04.11-59-13.webm
It is not a substitute to proper Z range filtering of vector layers (lacks a dedicated UI, optimizations, etc.) but it does allow us to do some interesting experiments using rule-based rendering using pre-existing z(geom) z_min(geom) and z_max(geom) functions.