Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scales with date / datetime input are broken #111

Open
anthonynorth opened this issue Jan 22, 2024 · 1 comment
Open

Scales with date / datetime input are broken #111

anthonynorth opened this issue Jan 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@anthonynorth
Copy link
Member

Continuous scales should support dates and datetimes. Discrete scales should support dates. Underlying scales::train_continuous() is coercing POSIXt as numeric, and Date as integer.
@anthonynorth anthonynorth added the bug Something isn't working label Jan 22, 2024
@anthonynorth
Copy link
Member Author

Edit: There are more blockers than just scales::trans_continuous(). POSIXt and Date vectors are serialised as text, so these will need to be fixed up in the client, possibly with just vec.map((x) => new Date(x))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonynorth