-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.7 / Cython 28.5 build fails #31
Comments
I think I'm having the same issues. Fix would be appreciated! |
I confirm that the above fix works with Python 3.7.3 and Cython 0.29.13. |
ti250
added a commit
to ti250/DAWG-patched
that referenced
this issue
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to build this with Python 3.7 and Cython 28.5.
python setup.py install
gives several compilation errors related to the new Python 3.7 C-API.I understand that I seem to need to run the
update_cpp.sh
script. This gives me a Cython compilation error, which is fixed by the below patch. Re-generating the C++ files then works, and so does installing the package. I'm hesitant to open a pull request because a) there are enormous changes to the checked-in C++ files, and b) I'm not sure if my change is a very good idea. I'm not too familiar with Cython, unfortunately. Maybe someone can help me out.The aforementioned patch:
The text was updated successfully, but these errors were encountered: