Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom rocm hip and c++ extensions #2342

Open
salykova opened this issue Dec 31, 2022 · 5 comments · May be fixed by #3197
Open

Custom rocm hip and c++ extensions #2342

salykova opened this issue Dec 31, 2022 · 5 comments · May be fixed by #3197
Labels
advanced amd ciflow/rocm docathon-h2-2023 module: rocm triaged Issues has been triaged

Comments

@salykova
Copy link

salykova commented Dec 31, 2022 •
edited by pytorch-bot bot
Loading

🚀 The feature, motivation and pitch

Dear PyTorch developers and community,

We have nice tutorial cpp_extension on custom cuda extensions written by Peter Goldsborough. I’m wondering if the same can be done but on AMD GPUs with kernels written using rocm HIP. I mean the following: call custom forward+backward hip kernel from pytorch and include it in deep learning pipeline. Is it currently supported and are there any limitations?

Does somebody have experience of writing custom hip/c++ kernels and using them in pytorch?

cc @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport
@samdow samdow added the triaged Issues has been triaged label Jan 3, 2023
@svekars svekars transferred this issue from pytorch/pytorch May 24, 2023
@svekars
Copy link
Contributor

svekars commented May 24, 2023

@jeffdaily

@jithunnair-amd
Copy link

@jeffdaily We have some internal documentation that highlights some of the differences in enabling PyTorch extensions for ROCm. Shall I put that together into something we can publish on the pytorch documentation?

@svekars svekars added amd advanced docathon-h1-2023 A label for the docathon in H1 2023 labels May 30, 2023
@jeffdaily
Copy link

/assigntome

@svekars
Copy link
Contributor

svekars commented Oct 24, 2023

This issue has been unassigned due to inactivity. If you are still planning to work on this, you can still send a PR referencing this issue.

@svekars svekars added docathon-h2-2023 and removed docathon-h1-2023 A label for the docathon in H1 2023 labels Oct 30, 2023
@guptaaryan16
Copy link

/assigntome

@guptaaryan16 guptaaryan16 removed their assignment Nov 3, 2023
@ahoblitz ahoblitz removed their assignment Nov 10, 2023
@hongxiayang hongxiayang mentioned this issue Feb 8, 2024
Open
@naromero77amd naromero77amd linked a pull request Dec 20, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
advanced amd ciflow/rocm docathon-h2-2023 module: rocm triaged Issues has been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ROCm] Update C++ Extension Tutorial for AMD GPU naromero77amd/tutorials
7 participants
@jeffdaily @svekars @ahoblitz @samdow @jithunnair-amd @salykova @guptaaryan16