Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wrong right commit is selected on LLM dashboards #6363

Open
huydhn opened this issue Mar 5, 2025 · 0 comments
Open

The wrong right commit is selected on LLM dashboards #6363

huydhn opened this issue Mar 5, 2025 · 0 comments
Assignees

Comments

@huydhn
Copy link
Contributor

huydhn commented Mar 5, 2025

I notice this small issue when taking the snapshot link to LLM dashboards. For example, https://hud.pytorch.org/benchmark/llms?startTime=Wed%2C%2026%20Feb%202025%2020%3A09%3A19%20GMT&stopTime=Wed%2C%2005%20Mar%202025%2020%3A09%3A19%20GMT&granularity=day&lBranch=main&lCommit=257e200a2537a8175392d3bb285473ab80867576&rBranch=main&rCommit=257e200a2537a8175392d3bb285473ab80867576&repoName=vllm-project%2Fvllm&benchmarkName=&modelName=All%20Models&backendName=All%20Backends&modeName=All%20Modes&dtypeName=All%20DType&deviceName=All%20Devices&archName=All%20Platforms sets lCommit and rCommit parameters to 257e200a2537a8175392d3bb285473ab80867576, however, loading the page show the wrong right commit where I think it points to the latest commit instead.

Image

cc @yangw-dev

@yangw-dev yangw-dev self-assigned this Mar 5, 2025
huydhn pushed a commit that referenced this issue Mar 5, 2025
#6363

this is a typo when refactor the benchmark code, simply remove the [], I
think visual studio auto-gen triggered it
Camyll pushed a commit that referenced this issue Mar 8, 2025
#6363

this is a typo when refactor the benchmark code, simply remove the [], I
think visual studio auto-gen triggered it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants