Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record failed benchmark runs in the database #6294

Open
huydhn opened this issue Feb 14, 2025 · 2 comments
Open

Record failed benchmark runs in the database #6294

huydhn opened this issue Feb 14, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@huydhn
Copy link
Contributor

huydhn commented Feb 14, 2025

Atm, when a benchmark job failed, nothing will be uploaded to the database. However, this makes it difficult to differentiate between a failed benchmark run and no benchmark run because there are no record in both cases.

See the convo on #6277 (comment)

cc @yangw-dev

@huydhn
Copy link
Contributor Author

huydhn commented Feb 19, 2025

To fix this, we will need to keep that in a dedicate conclusion field. The metric can probably be set to empty (or 0). This approach will work with #6277 (comment) without any change on HUD

@yangw-dev
Copy link
Contributor

yangw-dev commented Feb 26, 2025

short-term, upload benchmark with no data but extra_Info with conclusion field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Status: In Progress
Development

No branches or pull requests

3 participants