Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the comparison view between base and new commit #6293

Open
huydhn opened this issue Feb 14, 2025 · 0 comments
Open

Revisit the comparison view between base and new commit #6293

huydhn opened this issue Feb 14, 2025 · 0 comments

Comments

@huydhn
Copy link
Contributor

huydhn commented Feb 14, 2025

Two questions to cover:

  • The option we are using atm is to default the base commit to the oldest commit and the new commit to the latest commit in the selected window. There are cases where it's desirable to set both base and new commit to the latest commit Filter out devices that are not run #6277 (comment). We probably want to debate more on which is more useful as the default.
  • If there is no overlapping between the base and new commit, for example, one running CPU, the other running GPU benchmark. Or one running Android, the other running iOS. Should we show nothing, or should we show the results from the new commit (the current behavior)

cc @yangw-dev

@huydhn huydhn moved this to Ready in ExecuTorch Benchmark Feb 14, 2025
@huydhn huydhn changed the title Revisit the default choice for base and new commit Revisit the comparison between base and new commit Feb 14, 2025
@huydhn huydhn changed the title Revisit the comparison between base and new commit Revisit the comparison diff between base and new commit Feb 14, 2025
@huydhn huydhn changed the title Revisit the comparison diff between base and new commit Revisit the comparison view between base and new commit Feb 14, 2025
@huydhn huydhn moved this to Cold Storage in PyTorch OSS Dev Infra Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Status: Cold Storage
Development

No branches or pull requests

1 participant