-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to GNU Autoconf 2.72 #115765
Comments
The |
cc. @corona10 |
Seems our usage of |
Well, the |
…e.ac Instead use AC_CHECK_TYPES.
…115792) Instead use AC_CHECK_TYPES.
…onfigure.ac (pythonGH-115792) Instead use AC_CHECK_TYPES. (cherry picked from commit baae73d) Co-authored-by: Erlend E. Aasland <[email protected]>
…16016) Rewrite using AX_CHECK_DEFINE and AC_CHECK_TYPES.
Preparations for GNU Autoconf 2.72 have landed. It looks like Ubuntu 24.04 will ship with GNU Autoconf 2.71, though. @corona10, what do you think of switching to an autoconf docker/podman image again? |
|
@corona10, IIRC one of the concerns with the container image, was that our CI relied on an external service; network issues or quay.io downtime can make jobs fail. If we go for such a solution, we should have a broader discussion. |
@erlend-aasland |
Looks promising! |
So, in this case, my suggestion would be.
|
Great; I say go for it 😀 let's propose it on Discourse. |
That would also make it easier for us to update the autoconf-archive macros. |
Here is my PoC
|
PoC is not perfect but that’s why PoC :) |
👉 https://discuss.python.org/t/pinning-gnu-autotools-using-the-github-container-registry/47437 |
…e.ac (python#115792) Instead use AC_CHECK_TYPES.
…ac (python#116016) Rewrite using AX_CHECK_DEFINE and AC_CHECK_TYPES.
…ac (python#116016) Rewrite using AX_CHECK_DEFINE and AC_CHECK_TYPES.
…e.ac (python#115792) Instead use AC_CHECK_TYPES.
…ac (python#116016) Rewrite using AX_CHECK_DEFINE and AC_CHECK_TYPES.
A few months later, we've now got the CPython devcontainers 🥳 Switching to 2.72 should be pretty easy now. Let's do it now that we're in 3.14 alpha. I'll prepare a PR a week or so after landing #117815 (I'd like to let that PR live in |
See erlend-aasland/cpython@859870a for a draft. |
I forgot some doc and |
so a bit annoyingly this now means that one cannot autoconf on the most popular linux distribution's most recent lts release (which isn't even that old) ubuntu 24.04 which ships with autoconf 2.71 this makes it difficult to package for deadsnakes as well -- I'm hoping to just patch out the autoconf version requirement and continue on as usual. it doesn't seem to actually need the most recent version? |
Fedora 40, which is still a supported version, is also affected the same way (autoconf 2.71 still there). |
Feature or enhancement
Autoconf 2.72 was released 2023-12-22. Relevant highlights (some C&P verbatim) from the release announcement:
AC_USE_SYSTEM_EXTENSIONS
now enables C23 Annex F extensionsby defining
__STDC_WANT_IEC_60559_EXT__
(is this a problem?)Autoconf now quotes<= not worth the churn'like this'
instead of`like this'
; perhaps we should clean up our quoting in a separate first, so the 2.72 change is easier to review.including CheriBSD, Darwin (macOS), GNU Guix, OS/2, z/OS, Bash 5.2,
the BusyBox shell and utilities, Clang/LLVM version 16, the upcoming
GCC version 14, etc.
The other version requirements (Perl, M4, etc.) should not affect us.
Preliminary actions:
Linked PRs
The text was updated successfully, but these errors were encountered: