-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove un-necessary socket requirements in async tests #128404
Comments
Co-authored-by: Kumar Aditya <[email protected]>
@graingert Are there many other tests that rely on the |
I think there's only 3-4 files left. The last ones I want to touch are test_coroutine.py and test_asyncgens.py because they need a bit of thought. I'd like them split into using framework free code to test the object, and tests that test how asyncio interact with the object moved into test_asyncio. This will involve some duplication I think. |
Let's now use this issue, and later create issues for |
I've gone with this issue currently, for test_asyngens as it's currently a relatively minor rearrangement to start with. I'll do another issue for duplicating auditing the tests that still use asyncio.run/loop.run_until_complete and creating tests that work on wasi etc, while keeping the tests that verify the asyncio integration |
Proposal:
the builtins async tests should run coroutines using coro.send(None) because they don't need an async framework to run. This would remove asyncio from the tests and support running on emscripten/wasi
Has this already been discussed elsewhere?
No response given
Links to previous discussion of this feature:
No response
Linked PRs
The text was updated successfully, but these errors were encountered: