Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDFLAGS and LIBS not used consistently in configure #128354

Open
zanieb opened this issue Dec 30, 2024 · 0 comments
Open

LDFLAGS and LIBS not used consistently in configure #128354

zanieb opened this issue Dec 30, 2024 · 0 comments
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@zanieb
Copy link
Contributor

zanieb commented Dec 30, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Following up on #128322, I noticed that the same pattern of setting LDFLAGS instead of LIBS is used frequently. Additionally, there is not consistency in the ordering of the added libraries, e.g., LIBS="$LIBS ..." vs LIBS="... $LIBS".

For cases where the linking order matters, I believe using LDFLAGS is incorrect and the existing $LIBS should always come first.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@zanieb zanieb added the type-bug An unexpected behavior, bug, or error label Dec 30, 2024
@erlend-aasland erlend-aasland added the build The build process and cross-build label Dec 30, 2024
@zanieb zanieb mentioned this issue Dec 30, 2024
Merged
erlend-aasland pushed a commit that referenced this issue Jan 3, 2025
@zanieb
gh-128354: Consistently use LIBS over LDFLAGS in library build checks (…
b75ed95 
…#128359)
zanieb added a commit to zanieb/cpython that referenced this issue Jan 4, 2025
@zanieb
[3.13] pythongh-128354: Consistently use LIBS over LDFLAGS in library…
f6b30a5 
… build checks (pythonGH-128359)

(cherry picked from commit b75ed95)

Co-authored-by: Zanie Blue <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jan 4, 2025
Merged
zanieb added a commit to zanieb/cpython that referenced this issue Jan 4, 2025
@zanieb
[3.12] pythongh-128354: Consistently use LIBS over LDFLAGS in library…
789f6cf 
… build checks (pythonGH-128359)

(cherry picked from commit b75ed95)

Co-authored-by: Zanie Blue <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jan 4, 2025
Merged
erlend-aasland pushed a commit that referenced this issue Jan 4, 2025
@zanieb
[3.12] gh-128354: Consistently use LIBS over LDFLAGS in library build… (
f2cc565 
#128466)

(cherry picked from commit b75ed95)
erlend-aasland pushed a commit that referenced this issue Jan 4, 2025
@zanieb
[3.13] gh-128354: Consistently use LIBS over LDFLAGS in library build… (
855af3b 
#128465)

(cherry picked from commit b75ed95)
WolframAlph pushed a commit to WolframAlph/cpython that referenced this issue Jan 4, 2025
@zanieb @WolframAlph
pythongh-128354: Consistently use LIBS over LDFLAGS in library build …
29bd2e5 
…checks (python#128359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zanieb @erlend-aasland