Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIL is not properly disabled for _freeze_module.vcxproj #128345

Open
TheShermanTanker opened this issue Dec 30, 2024 · 1 comment
Open

GIL is not properly disabled for _freeze_module.vcxproj #128345

TheShermanTanker opened this issue Dec 30, 2024 · 1 comment
Labels
build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error

Comments

@TheShermanTanker
Copy link
Contributor

TheShermanTanker commented Dec 30, 2024

Bug report

Bug description:

The _freeze_module.vcxproj file is looking for #undef Py_GIL_DISABLED, but that was changed to /* #define Py_GIL_DISABLED 1 */ some time ago, so the build system ends up looking to replace a line that doesn't exist, the result is that the freeze Python never has GIL disabled even if it was requested during the build

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs

@TheShermanTanker TheShermanTanker added the type-bug An unexpected behavior, bug, or error label Dec 30, 2024
@Eclips4 Eclips4 added build The build process and cross-build OS-windows labels Dec 30, 2024
@TheShermanTanker TheShermanTanker changed the title GIL is not properly disabled for freeze Python on Windows GIL is not properly disabled for _freeze_module.vcxproj Dec 30, 2024
@zooba
Copy link
Member

zooba commented Jan 1, 2025

Arguably it's better to leave the GIL enabled for this tool, as it means that if the developer makes a change that crashes under nogil, they'll still get a build to test with. It's a real pain to debug crashes during the build process.

On the other hand, if nogil being enabled generates alternate bytecode (I don't think it does? Yet?), then yeah, it'll be important to have it active in this process so that it generates the right modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants