You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The _freeze_module.vcxproj file is looking for #undef Py_GIL_DISABLED, but that was changed to /* #define Py_GIL_DISABLED 1 */ some time ago, so the build system ends up looking to replace a line that doesn't exist, the result is that the freeze Python never has GIL disabled even if it was requested during the build
TheShermanTanker
changed the title
GIL is not properly disabled for freeze Python on Windows
GIL is not properly disabled for _freeze_module.vcxproj
Dec 30, 2024
Arguably it's better to leave the GIL enabled for this tool, as it means that if the developer makes a change that crashes under nogil, they'll still get a build to test with. It's a real pain to debug crashes during the build process.
On the other hand, if nogil being enabled generates alternate bytecode (I don't think it does? Yet?), then yeah, it'll be important to have it active in this process so that it generates the right modules.
Bug report
Bug description:
The _freeze_module.vcxproj file is looking for
#undef Py_GIL_DISABLED
, but that was changed to/* #define Py_GIL_DISABLED 1 */
some time ago, so the build system ends up looking to replace a line that doesn't exist, the result is that the freeze Python never has GIL disabled even if it was requested during the buildCPython versions tested on:
CPython main branch
Operating systems tested on:
Windows
Linked PRs
The text was updated successfully, but these errors were encountered: