-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TODO] Rewrite the plugin fetcher as a Sphinx extension #13081
Comments
I lost track of this and Bruno's endorsement of the idea (#12607 (comment)). So I'm filing this issue for visibility. |
This will need a new directive like https://github.com/ansible/ansible-lint/blob/a85f191/docs/rules_table_generator_ext.py#L38-L76. And some cache processing, perhaps: https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/01bb987/src/sphinxcontrib/towncrier/ext.py#L295-L326. |
Generally I like committing the resulting rst because it's easier to review the changes and you can see problems in the generation that you would miss otherwise. In that case the plugin list is very stable, automated, and barely need a review so +1 from me. |
I prefer the split of generate and doc build I don't want to make general doc building dependent on a potentially failing process |
@RonnyPfannschmidt not even with caching? |
There already is caching |
Personally I don't get the benefit of this. There is a lot more complexity, more moving parts, potentially more stuff to take care of on Sphinx upgrades, more reasons for doc builds to fail locally, more cache stuff to take care of (e.g. for CI), etc. etc. What's the benefit? The only I can see is:
|
Actually @The-Compiler makes good points, perhaps @webknjaz may comment on them. I'm changing my previous "vote" to -0 for now. |
Hey @nicoddemus @bluetech @RonnyPfannschmidt @The-Compiler are y'all married to the idea of committing this table to the Git repo as RST? I know how to write an in-repo Sphinx extension that would do this on build with proper caching. This would eliminate the need to keep updating RST.
Originally posted by @webknjaz in #12607 (comment)
The text was updated successfully, but these errors were encountered: