Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why are we unquoting these variables? #702

Closed
tdas3001 opened this issue May 20, 2023 · 1 comment
Closed

Question: Why are we unquoting these variables? #702

tdas3001 opened this issue May 20, 2023 · 1 comment
Labels

Comments

@tdas3001
Copy link
Contributor

name = urllib.parse.unquote(name)
if user is not None:
user = urllib.parse.unquote(user)
if password is not None:
password = urllib.parse.unquote(password)

Why are we unquoting name, user and password? Are they being quoted somewhere in the code which we are trying to undo?

@philpep
Copy link
Contributor

philpep commented Aug 24, 2023

Because they can be passed in urlstring pytest --host 'ssh://some%40user@host'

@philpep philpep closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants