-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SVI tutorial code from MD code blocks into code cells #2714
Comments
Hey I'd be happy to do this.. but I noticed a lot of the code in markdown is actually pseudocode. For example:
Would you think it best to make this code runnable too? While we're on the above example, I think it would be best to add return statements to |
Hey @Padarn, good point. I think converting pseudocode to python throughout the notebook would increase clarity. |
Makes sense. I'll take a first crack at it then
…On Thu, 24 Dec 2020, 7:49 pm Armin Stepanjan, ***@***.***> wrote:
Hey @Padarn <https://github.com/Padarn>, good point. I think converting
pseudocode to python throughout the notebook would increase clarity.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2714 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRPN25R5QKFQPCJCTFLKTSWMTC5ANCNFSM4U3RHRVQ>
.
--
By communicating with Grab Inc and/or its subsidiaries, associate
companies and jointly controlled entities (“Grab Group”), you are deemed to
have consented to the processing of your personal data as set out in the
Privacy Notice which can be viewed at https://grab.com/privacy/
<https://grab.com/privacy/>
This email contains confidential information
and is only for the intended recipient(s). If you are not the intended
recipient(s), please do not disseminate, distribute or copy this email
Please notify Grab Group immediately if you have received this by mistake
and delete this email from your system. Email transmission cannot be
guaranteed to be secure or error-free as any information therein could be
intercepted, corrupted, lost, destroyed, delayed or incomplete, or contain
viruses. Grab Group do not accept liability for any errors or omissions in
the contents of this email arises as a result of email transmission. All
intellectual property rights in this email and attachments therein shall
remain vested in Grab Group, unless otherwise provided by law.
|
I've created a PR here: #2723 Few uncertainties around the best way to do this. The tutorial isn't really setup to be interactive, so I made a few modifications. Let me know what you think, I can continue with the others if we're broadly aligned. If you think the tutorials need more of a rework than this, I could be the wrong person :-) |
As it stands, a significant portion of the SVI tutorial code is written in markdown code blocks, rather than standalone Jupyter cells. When formatted this way, the tutorial's notebook cannot be excecuted and experimented with by the reader. I suggest that the markdown code blocks should be refactored into Jupyter code cells.
The text was updated successfully, but these errors were encountered: