tool: Update cad_audit_check.py #2548
Conversation
Fixed bug in WIP 5.0.0.25025
4. Removed from pyrevit.forms import alert (not needed)
26. Added class ButtonClass(Window), to manage my cancel button
98. Added a condition to the get_load_stat(cad, is_link) function
if status == "Loaded":
return "Loaded"
|
Automatic code review is enabled for this repository. Reviewing this PR now. |
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've reviewed the changes to cad_audit_check.py. The core improvements are good - adding proper "Loaded" status handling and improving button management with ButtonClass. I've suggested two minor improvements: removing a redundant function and maintaining consistency in status return formatting. Overall the changes are safe and well tested.
| window.close() | ||
| script.exit() | ||
|
|
||
|
|
||
| # Manage Flexform cancel using .NET System.Windows RoutedEventArgs Class | ||
| def cancel_clicked(sender, e): |
There was a problem hiding this comment.
The cancel_clicked function is now redundant since it's been moved to the ButtonClass class. Please remove this duplicate function since it's no longer used (the FlexForm now uses ButtonClass.cancel_clicked).
Co-authored-by: devloai[bot] <168258904+devloai[bot]@users.noreply.github.com>
|
@nasmovk can you check devlo's comment. After that I will merge |
|
I am about to push the release button and would like to include this one in the release. |
|
I would to the opposite as it has been done here, there's shouldn't be the need to create a class with a static method... just remove and remove ButtonClass altogether. |
|
I will check and update, if I can understand Andrea's remark. |
Sorry if I wasn't clear enough, I assumed that, since you put a class and a static method in the code, you knew the teminology 😅
I thought I already reviewed that, but it may be lost in the merge frenzy of the model checker competition. The StackOverflow answer you're referring to in the comments is overcomplicating a simpler solution: the OP had to just remove the parenthesis to make things work instead of The latter calls the function before passing it to the button, while the former passes the function itself to the button, so that it is called when the button is pressed. |
|
@nasmovk |
|
I'm away skiing for the weekend, but I promise to look at this as soon as I'm back. Looking forward to the v5 launch. |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25034+1241-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25034+1511-wip |
|
📦 New public release are available for 5.0.0.24174+2300 |
Update cad_audit_check.py
Description
Fixed bug in WIP 5.0.0.25025
This follows my testing of the first implementation of my cad_audit_check into pyRevit, based on my original Hackathon submittal
Removed from pyrevit.forms import alert (not needed)
Added class ButtonClass(Window), to manage my cancel button
Added a condition to the get_load_stat(cad, is_link) function
if status == "Loaded":
return "Loaded"
Tested in Revit 2024 & 2025