Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML Diagrams #178

Closed
ColtAllen opened this issue Feb 28, 2023 · 6 comments · Fixed by #210
Closed

UML Diagrams #178

ColtAllen opened this issue Feb 28, 2023 · 6 comments · Fixed by #210
Labels
docs Improvements or additions to documentation request discussion

Comments

@ColtAllen
Copy link
Collaborator

I created some UML diagrams while working on #177, which are shown below. Is it worth adding these to the new-release CI so they are auto-generated each time? Furthermore, are they worth adding to the documentation despite being rather developer-specific?

MMM

mmm_uml

CLV

clv_uml

MMM Tests

tests_mmm_uml

CLV Tests

tests_clv_uml

Note these diagrams only illustrate internal class methods/attributes and inheritance, and will not display imported function calls like clv.utils.to_xarray() and clv.utils.customer_lifetime_value().

To recreate these diagrams, install graphviz and pylint and run this CLI command:

$ pyreverse directory/path -f 'ALL' -o png

This will also create an additional packages.png file which should be deleted.

@ColtAllen ColtAllen added docs Improvements or additions to documentation request discussion labels Feb 28, 2023
@juanitorduz
Copy link
Collaborator

From a developer's perspective, these diagrams look very useful! So +1 to add them in the docs in such a way that is not immediately visible to the average user (might look scary) :)

@drbenvincent
Copy link
Contributor

I use this in CausalPy and have these saved and displayed. Do you propose to save and display the images similarly, or just to document that it is possible to create these images? Either way, I propose that this should happen in the new CONTRIBUTING.md which will appear when #203 is merged.

I don't have a strong opinion about which of the options we go with :)

@ColtAllen
Copy link
Collaborator Author

I use this in CausalPy and have these saved and displayed. Do you propose to save and display the images similarly, or just to document that it is possible to create these images? Either way, I propose that this should happen in the new CONTRIBUTING.md which will appear when #203 is merged.

I don't have a strong opinion about which of the options we go with :)

I think it would be a good addition to #203. The lifetimes documentation has something similar.

@drbenvincent
Copy link
Contributor

Did you want to take that on, or do you mind if I give it a go?

@ColtAllen
Copy link
Collaborator Author

@drbenvincent I'm busy with a few other PRs right now, so feel free to work on this one.

@drbenvincent
Copy link
Contributor

Note to self: Do this after #207 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation request discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants